linux-kernel - Re: [PATCH 1/1] kconfig: fix 'space' to (de)select options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQTUCQ4rdnwm-KMPoQxJMLF+HTFOvAM_uw15dG+HuBhhA@mail.gmail.com>
Date: Tue, 24 Jun 2025 19:03:54 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Cherniaev Andrei <dungeonlords789@...er.com>
Cc: linux-kbuild@...r.kernel.org, yann.morin.1998@...e.fr, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] kconfig: fix 'space' to (de)select options

On Sat, Jun 21, 2025 at 5:51 PM Cherniaev Andrei
<dungeonlords789@...er.com> wrote:
>
> Fix that by treating 'space' as we treat y/m/n, ie. as an action key, not as shortcut to jump to prompt. This is copy of commit https://gitlab.com/buildroot.org/buildroot/-/raw/master/support/kconfig/patches/16-fix-space-to-de-select-options.patch
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@...e.fr>
> Signed-off-by: Cherniaev Andrei <dungeonlords789@...er.com>
> ---
>  scripts/kconfig/lxdialog/menubox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
> index 6e6244df0c56..d4c19b7beebb 100644
> --- a/scripts/kconfig/lxdialog/menubox.c
> +++ b/scripts/kconfig/lxdialog/menubox.c
> @@ -264,7 +264,7 @@ int dialog_menu(const char *title, const char *prompt,
>                 if (key < 256 && isalpha(key))
>                         key = tolower(key);
>
> -               if (strchr("ynmh", key))
> +               if (strchr("ynmh ", key))
>                         i = max_choice;
>                 else {
>                         for (i = choice + 1; i < max_choice; i++) {
> --
> 2.48.1
>

I will take directly from Buildroot (with your signed-off),
as this commit provides more details about how to reproduce the issue.

https://gitlab.com/buildroot.org/buildroot/-/commit/c6597e5aa3fa4bb52e9749797c90467083aa363b

Thanks
-- 
Best Regards
Masahiro Yamada