linux-kernel - Re: [PATCH v3 RESEND] media: i2c: Add OV05C10 camera sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFp78tqHhe_IhV6d@kekkonen.localdomain>
Date: Tue, 24 Jun 2025 10:20:34 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Mehdi Djait <mehdi.djait@...ux.intel.com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	"Nirujogi, Pratap" <pnirujog@....com>,
	Pratap Nirujogi <pratap.nirujogi@....com>, mchehab@...nel.org,
	hverkuil@...all.nl, bryan.odonoghue@...aro.org, krzk@...nel.org,
	dave.stevenson@...pberrypi.com, hdegoede@...hat.com,
	jai.luthra@...asonboard.com, tomi.valkeinen@...asonboard.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	benjamin.chan@....com, bin.du@....com, grosikop@....com,
	king.li@....com, dantony@....com, vengutta@....com,
	Svetoslav.Stoilov@....com, Yana.Zheleva@....com
Subject: Re: [PATCH v3 RESEND] media: i2c: Add OV05C10 camera sensor driver

On Tue, Jun 24, 2025 at 10:19:35AM +0000, Sakari Ailus wrote:
> Hi Mehdi,
> 
> On Tue, Jun 24, 2025 at 10:35:18AM +0200, Mehdi Djait wrote:
> > Hi Laurent, Hi Pratap,
> > 
> > Thank you for the patch
> > 
> > On Tue, Jun 24, 2025 at 01:05:03AM +0300, Laurent Pinchart wrote:
> > > (CC'ing Mehdi)
> > > 
> > > On Mon, Jun 23, 2025 at 05:51:48PM -0400, Nirujogi, Pratap wrote:
> > > > On 6/16/2025 6:49 PM, Nirujogi, Pratap wrote:
> > > > >>> +static int ov05c10_probe(struct i2c_client *client)
> > > > >>> +{
> > > > >>> +     struct ov05c10 *ov05c10;
> > > > >>> +     u32 clkfreq;
> > > > >>> +     int ret;
> > > > >>> +
> > > > >>> +     ov05c10 = devm_kzalloc(&client->dev, sizeof(*ov05c10), 
> > > > >>> GFP_KERNEL);
> > > > >>> +     if (!ov05c10)
> > > > >>> +             return -ENOMEM;
> > > > >>> +
> > > > >>> +     struct fwnode_handle *fwnode = dev_fwnode(&client->dev);
> > > > >>> +
> > > > >>> +     ret = fwnode_property_read_u32(fwnode, "clock-frequency", 
> > > > >>> &clkfreq);
> > > > >>> +     if (ret)
> > > > >>> +             return  dev_err_probe(&client->dev, -EINVAL,
> > > > >>> +                                   "fail to get clock freq\n");
> > > > >>
> > > > >> Let's try to land
> > > > >> https://lore.kernel.org/linux-media/20250521104115.176950-1- 
> > > > >> mehdi.djait@...ux.intel.com/
> > > > >> and replace the code above with devm_v4l2_sensor_clk_get().
> > > > >>
> > > > > Ok, we will verify on our side.
> > > > 
> > > > We tried using devm_v4l2_sensor_clk_get() and found its required to add 
> > > > support for software_node to make it work with this driver.
> > > 
> > > Why is that ?
> > > 
> > > > Please refer 
> > > > the changes below and let us know if these should be submitted as a 
> > > > separate patch.
> > 
> > The helper is still not merged, so no patch is required.
> > 
> > I will see if a change is needed from the helper side or the OV05C10 side.
> 
> I wonder if there's a better way to figure out if you're running on a DT or
> ACPI based system than getting the device's parents and checking which one
> you find first, DT or ACPI. I think that should work for now at least.

Or, rather, checking for non-OF node here would probably work the best. I
wouldn't expect these to be software node based on DT systems ever.

-- 
Regards,

Sakari Ailus