linux-kernel - Re: [PATCH v4 3/3] platform/x86: Use i2c adapter name to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a74c711-0d9c-8013-dc92-82ffd0d7d416@linux.intel.com>
Date: Tue, 24 Jun 2025 15:07:16 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: andi.shyti@...nel.org
cc: Pratap Nirujogi <pratap.nirujogi@....com>, andi.shyti@...nel.org, 
    rdunlap@...radead.org, Hans de Goede <hdegoede@...hat.com>, 
    sfr@...b.auug.org.au, linux-next@...r.kernel.org, 
    linux-i2c@...r.kernel.org, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, benjamin.chan@....com, bin.du@....com, 
    gjorgji.rosikopulos@....com, king.li@....com, dantony@....com
Subject: Re: [PATCH v4 3/3] platform/x86: Use i2c adapter name to fix build
 errors

Hi Andi,

(ping)

It seems by now people are starting to send workaround fixes (build only 
with =m) as this series is still pending and compile is breaking because 
of it.

I'm fine with you taking the entire series through i2c, or just let me 
know if you want me to take it through pdx86 tree instead.

On Tue, 10 Jun 2025, Ilpo Järvinen wrote:
> On Mon, 9 Jun 2025, Pratap Nirujogi wrote:
> 
> > Use adapater->name inplace of adapter->owner->name to fix
> > build issues when CONFIG_MODULES is not defined.
> > 
> > Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> > Reported-by: Randy Dunlap <rdunlap@...radead.org>
> > Link: https://lore.kernel.org/all/04577a46-9add-420c-b181-29bad582026d@infradead.org
> > Tested-by: Randy Dunlap <rdunlap@...radead.org>
> > Signed-off-by: Pratap Nirujogi <pratap.nirujogi@....com>
> > ---
> >  drivers/platform/x86/amd/amd_isp4.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/platform/x86/amd/amd_isp4.c b/drivers/platform/x86/amd/amd_isp4.c
> > index 0cc01441bcbb..9f291aeb35f1 100644
> > --- a/drivers/platform/x86/amd/amd_isp4.c
> > +++ b/drivers/platform/x86/amd/amd_isp4.c
> > @@ -11,6 +11,7 @@
> >  #include <linux/mutex.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/property.h>
> > +#include <linux/soc/amd/isp4_misc.h>
> >  #include <linux/string.h>
> >  #include <linux/types.h>
> >  #include <linux/units.h>
> > @@ -151,7 +152,7 @@ MODULE_DEVICE_TABLE(acpi, amdisp_sensor_ids);
> >  
> >  static inline bool is_isp_i2c_adapter(struct i2c_adapter *adap)
> >  {
> > -	return !strcmp(adap->owner->name, "i2c_designware_amdisp");
> > +	return !strcmp(adap->name, AMDISP_I2C_ADAP_NAME);
> >  }
> >  
> >  static void instantiate_isp_i2c_client(struct amdisp_platform *isp4_platform,
> 
> Acked-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> 
> Andi, do you want to take this fix series through i2c tree or do you 
> prefer me to take them through pdx86 tree?


-- 
 i.