linux-kernel - Re: [RFC 1/2] lib/vsprintf: Add support for pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFqj7CYRcEHFAi2e@casper.infradead.org>
Date: Tue, 24 Jun 2025 14:11:08 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Anshuman Khandual <anshuman.khandual@....com>
Cc: linux-mm@...ck.org, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Petr Mladek <pmladek@...e.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Jonathan Corbet <corbet@....net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org
Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t

On Fri, Jun 20, 2025 at 01:42:53PM +0530, Anshuman Khandual wrote:
> On 19/06/25 6:56 PM, Matthew Wilcox wrote:
> > Unfortunately, the one example you've converted shows why this is a bad
> > idea.  You're passing a pmd_t pointer to a function which is assuming a
> > pte_t pointer.  And a pmd_t and a pte_t are sometimes different sizes!
> > (eg sometimes one is 64 bit and the other 32 bit).
> 
> As discussed on a separate thread, this might be addressed via separate
> printf formats for each page table level e.g %ppte, %ppmd, and %ppud etc. 

There's still no typechecking!