linux-kernel - Re: [PATCH] staging: media: atomisp: remove debug sysfs attributes active_bo and free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFqnK5nIHilUSxPq@smile.fi.intel.com>
Date: Tue, 24 Jun 2025 16:24:59 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>
Cc: andy@...nel.org, hdegoede@...hat.com, mchehab@...nel.org,
	sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	linux-staging@...ts.linux.dev, shuah@...uxfoundation.org,
	linux-kernel-mentees@...ts.linux.dev, dan.carpenter@...aro.org
Subject: Re: [PATCH] staging: media: atomisp: remove debug sysfs attributes
 active_bo and free_bo

On Tue, Jun 24, 2025 at 04:08:41PM +0300, Abdelrahman Fekry wrote:
> The sysfs attributes active_bo and free_bo expose internal buffer
> state used only for debugging purposes. These are not part of
> any standard kernel ABI and needs to be removed before this
> driver can be moved out of drivers/staging.
> 
> - Remove active_bo and free_bo attributes
> - Remove group registration calls form hmm_init() and hmm_cleanup()

Suggested-by: ?

...

> +	/* Removed sysfs group registration for active_bo and free_bo attributes */

> +
> +	/* Removed sysfs group remove for active_bo and free_bo attributes */

These comments do not bring a value, no need to have them.

With the above fixed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko