linux-kernel - Re: [PATCH wireless-next v2] wifi: mac80211: consider links for validating SCAN_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e83c0841a3875aebcbb830949abc44d909d64da4.camel@sipsolutions.net>
Date: Tue, 24 Jun 2025 15:26:57 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Aditya Kumar Singh <aditya.kumar.singh@....qualcomm.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH wireless-next v2] wifi: mac80211: consider links for
 validating SCAN_FLAG_AP in scan request during MLO

On Tue, 2025-06-24 at 14:25 +0530, Aditya Kumar Singh wrote:
> Commit 78a7a126dc5b ("wifi: mac80211: validate SCAN_FLAG_AP in scan request
> during MLO") introduced a check that rejects scan requests if any link is
> already beaconing. This works fine when all links share the same radio, but
> breaks down in multi-radio setups.
> 
> Consider a scenario where a 2.4 GHz link is beaconing and a scan is
> requested on a 5 GHz link, each backed by a different physical radio. The
> current logic still blocks the scan, even though it should be allowed. As a
> result, interface bring-up fails unnecessarily in valid configurations.
> 
> Fix this by checking whether the scan is being requested on the same
> underlying radio as the beaconing link. Only reject the scan if it targets
> a link that is already beaconing and the SCAN_FLAG_AP is not set. This
> ensures correct behavior in multi-radio environments and avoids false
> rejections.
> 

This triggers a warning in ieee80211_is_radio_idx_in_scan_req() in hwsim
tests.

johannes