linux-kernel - Re: [PATCH] usb: chipidea: udc: Use usb_endpoint_is_isoc_in() rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <igmzazos37rffzpuvyy5ubrwozfznphtenkdwosjceq7gcakzw@dtdxbfzhy64v>
Date: Wed, 25 Jun 2025 10:13:48 +0800
From: Xu Yang <xu.yang_2@....com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-usb@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Peter Chen <peter.chen@...nel.org>, 
	LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Chen Ni <nichen@...as.ac.cn>
Subject: Re: [PATCH] usb: chipidea: udc: Use usb_endpoint_is_isoc_in() rather
 than duplicating its implementation

On Tue, Jun 24, 2025 at 05:40:17PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 24 Jun 2025 17:30:52 +0200
> 
> Reuse existing functionality from usb_endpoint_is_isoc_in() instead of
> keeping duplicate source code.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/usb/chipidea/udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 64a421ae0f05..75705089136c 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1992,7 +1992,7 @@ static struct usb_ep *ci_udc_match_ep(struct usb_gadget *gadget,
>  	struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);
>  	struct usb_ep *ep;
>  
> -	if (usb_endpoint_xfer_isoc(desc) && usb_endpoint_dir_in(desc)) {
> +	if (usb_endpoint_is_isoc_in(desc)) {
>  		list_for_each_entry_reverse(ep, &ci->gadget.ep_list, ep_list) {
>  			if (ep->caps.dir_in && !ep->claimed)
>  				return ep;

Ok for me.
Reviewed-by: Xu Yang <xu.yang_2@....com>

> -- 
> 2.50.0
>