linux-kernel - Re: [PATCH] staging: sm750fb: Mark g_fbmode as a pointer to const pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e477d4a1-a941-4301-b295-c245f9023cd3@suswa.mountain>
Date: Wed, 25 Jun 2025 14:19:42 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Pratibimba Khadka <pratibimbakhadka@...il.com>
Cc: sudipm.mukherjee@...il.com, Teddy Wang <teddy.wang@...iconmotion.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER" <linux-fbdev@...r.kernel.org>,
	"open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: sm750fb: Mark g_fbmode as a pointer to const
 pointer

On Wed, Jun 25, 2025 at 10:40:26AM +0545, Pratibimba Khadka wrote:
> Fixes a checkpatch warning:
> WARNING: static const char * array should probably be static const char * const
> 
> The array `g_fbmode` contains constant string pointers that are not
> supposed to be modified. By declaring it as `const char * const`,
> both the string literals and the pointers themselves are protected
> from accidental modification, which improves code safety and clarity.
> 

You need to compile test code before sending it.  It can't be changed
from being a NULL pointer now so it breaks.

regards,
dan carpenter