linux-kernel - Re: [PATCH 2/9] kasan: replace kasan_arch_is_ready with kasan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81a8b60be5b99ecd9b322d188738016376aff4aa.camel@sipsolutions.net>
Date: Wed, 25 Jun 2025 14:23:57 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Christophe Leroy <christophe.leroy@...roup.eu>, Sabyrzhan Tasbolatov	
 <snovitoll@...il.com>, ryabinin.a.a@...il.com, glider@...gle.com, 
	andreyknvl@...il.com, dvyukov@...gle.com, vincenzo.frascino@....com, 
	catalin.marinas@....com, will@...nel.org, chenhuacai@...nel.org,
 kernel@...0n.name, 	maddy@...ux.ibm.com, mpe@...erman.id.au,
 npiggin@...il.com, hca@...ux.ibm.com, 	gor@...ux.ibm.com,
 agordeev@...ux.ibm.com, borntraeger@...ux.ibm.com, 	svens@...ux.ibm.com,
 richard@....at, anton.ivanov@...bridgegreys.com, 
	dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org, 
	tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org,
 hpa@...or.com, 	chris@...kel.net, jcmvbkbc@...il.com,
 akpm@...ux-foundation.org
Cc: guoweikang.kernel@...il.com, geert@...ux-m68k.org, rppt@...nel.org, 
	tiwei.btw@...group.com, richard.weiyang@...il.com, benjamin.berg@...el.com,
 	kevin.brodsky@....com, kasan-dev@...glegroups.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	loongarch@...ts.linux.dev, linuxppc-dev@...ts.ozlabs.org, 
	linux-s390@...r.kernel.org, linux-um@...ts.infradead.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/9] kasan: replace kasan_arch_is_ready with
 kasan_enabled

On Wed, 2025-06-25 at 12:27 +0200, Christophe Leroy wrote:
> 
> Le 25/06/2025 à 11:52, Sabyrzhan Tasbolatov a écrit :
> > Replace the existing kasan_arch_is_ready() calls with kasan_enabled().
> > Drop checks where the caller is already under kasan_enabled() condition.
> 
> If I understand correctly, it means that KASAN won't work anymore 
> between patch 2 and 9, because until the arch calls kasan_init_generic() 
> kasan_enabled() will return false.
> 
> The transition should be smooth and your series should remain bisectable.
> 
> Or am I missing something ?
> 

Seems right to me, it won't work for architectures that define
kasan_arch_is_ready themselves I think?

But since they have to literally #define it, could #ifdef on that
temporarily?

johannes