linux-kernel - 回复: [PATCH v6 01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY1PPFECF6DCA7C0493FE1041C661918E91DA7BA@TY1PPFECF6DCA7C.apcprd06.prod.outlook.com>
Date: Wed, 25 Jun 2025 02:54:38 +0000
From: 潘闯 <panchuang@...o.com>
To: Thomas Gleixner <tglx@...utronix.de>, Miquel Raynal
	<miquel.raynal@...tlin.com>
CC: 李扬韬 <frank.li@...o.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	"Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano
	<daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, Lukasz Luba
	<lukasz.luba@....com>, Markus Mayer <mmayer@...adcom.com>, Broadcom internal
 kernel review list <bcm-kernel-feedback-list@...adcom.com>, Florian Fainelli
	<florian.fainelli@...adcom.com>, Shawn Guo <shawnguo@...nel.org>, Sascha
 Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
	<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, zhanghongchen
	<zhanghongchen@...ngson.cn>, Yinbo Zhu <zhuyinbo@...ngson.cn>, Amit Kucheria
	<amitk@...nel.org>, Thara Gopinath <thara.gopinath@...il.com>,
	Niklas Söderlund <niklas.soderlund@...natech.se>, Geert
 Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>,
	Heiko Stuebner <heiko@...ech.de>, Bartlomiej Zolnierkiewicz
	<bzolnier@...il.com>, Krzysztof Kozlowski <krzk@...nel.org>, Alim Akhtar
	<alim.akhtar@...sung.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Vasily Khoruzhick
	<anarsoul@...il.com>, Yangtao Li <tiny.windzz@...il.com>, Chen-Yu Tsai
	<wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland
	<samuel@...lland.org>, Thierry Reding <thierry.reding@...il.com>, Jonathan
 Hunter <jonathanh@...dia.com>, Kunihiko Hayashi
	<hayashi.kunihiko@...ionext.com>, Masami Hiramatsu <mhiramat@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, Srinivas Pandruvada
	<srinivas.pandruvada@...ux.intel.com>, Greg KH <gregkh@...uxfoundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Nícolas F. R. A. Prado <nfraprado@...labora.com>, Conor
 Dooley <conor.dooley@...rochip.com>, Julien Panis <jpanis@...libre.com>, Arnd
 Bergmann <arnd@...db.de>, Uwe Kleine-König
	<u.kleine-koenig@...libre.com>, Colin Ian King <colin.i.king@...il.com>,
	Raphael Gallais-Pou <rgallaispou@...il.com>, Patrice Chotard
	<patrice.chotard@...s.st.com>, Jonathan Cameron
	<jonathan.cameron@...wei.com>, "Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Andrew Morton
	<akpm@...ux-foundation.org>, Costa Shulyupin <costa.shul@...hat.com>, Yury
 Norov <yury.norov@...il.com>, Cheng-Yang Chou <yphbchou0911@...il.com>, Caleb
 Sander Mateos <csander@...estorage.com>, "linux-pm@...r.kernel.org"
	<linux-pm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "linux-arm-msm@...r.kernel.org"
	<linux-arm-msm@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>, "linux-rockchip@...ts.infradead.org"
	<linux-rockchip@...ts.infradead.org>, "linux-samsung-soc@...r.kernel.org"
	<linux-samsung-soc@...r.kernel.org>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>, "linux-sunxi@...ts.linux.dev"
	<linux-sunxi@...ts.linux.dev>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>
Subject:
 回复: [PATCH v6 01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe()

Hi tglx and Miquèl,

On Tue, Jun 24 2025 at 16:13, tglx wrote:
> As you cited correctly I said back then:
> 
>   "So there is certainly an argument to be made that this particular
>   function should print a well formatted and informative error
>   message."
>
> This particular function is: devm_request_threaded_irq().
>
> IOW, I did not ask you should go an create a new one, right?

Thank you all for your valuable feedback and guidance regarding the recent patch. I am a bit confused because, in the v1 version, no new function was added. However, in v2, tglx suggested introducing a new function[1]. Now, I would greatly appreciate your advice on the appropriate approach:

  Should we directly integrate dev_err_probe() inside devm_request_threaded_irq()?
  Or should we create a wrapper function instead?

Thank you for your guidance.

[1]https://lore.kernel.org/all/87h6qpyzkd.ffs@tglx/

Thanks,

        PanChuang