linux-kernel - Re: [PATCH 0/4] Remove the wl1273 FM Radio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <cf3f3522-a3c8-43db-baad-198b9498d18c@app.fastmail.com>
Date: Wed, 25 Jun 2025 16:00:49 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: linux <linux@...blig.org>, "Lee Jones" <lee@...nel.org>,
 "Mauro Carvalho Chehab" <mchehab@...nel.org>, lgirdwood@...il.com,
 "Mark Brown" <broonie@...nel.org>, "Jaroslav Kysela" <perex@...ex.cz>,
 tiwai@...e.com
Cc: linux-media@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] Remove the wl1273 FM Radio

On Wed, Jun 25, 2025, at 15:32, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> I noticed that the wl1273 radio had an unused symbol, but then noticed
> it is on Arnd's unused driver list:
>   
> https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/
>
> So, delete it.
> The components seem pretty separable, except for Kconfig dependencies.
>
> That lore URL is over 75 chars, which checkpatch warns about,
> suggestions welcome.

Acked-by: Arnd Bergmann <arnd@...db.de>

For reference, the driver was added in 2010 with commit 383268a8e282
("[media] MFD: WL1273 FM Radio: MFD driver for the FM radio"). It
requires platform_data to be defined in a board file, but we never
had any such board files doing this upstream.

The chip is apparently the Bluetooth/Wifi combo chip on the Nokia N9
and others, and is supported for those subsystems by the wlcore
driver. Clearly nobody cared enough about FM radio functionality
for the past 15 years to add the missing bits.

The author was last active on the mailing list in 2012.

      Arnd