linux-kernel - Re: [PATCH] xfs: report a writeback error on a read() call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11735cf2e1893c14435c91264d58fae48be2973d.camel@kernel.org>
Date: Wed, 25 Jun 2025 10:06:48 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: Yafang Shao <laoar.shao@...il.com>, david@...morbit.com,
 djwong@...nel.org, 	linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, 	linux-xfs@...r.kernel.org,
 yc1082463@...il.com
Subject: Re: [PATCH] xfs: report a writeback error on a read() call

On Wed, 2025-06-25 at 04:56 -0700, Christoph Hellwig wrote:
> On Wed, Jun 25, 2025 at 07:49:31AM -0400, Jeff Layton wrote:
> > Another idea: add a new generic ioctl() that checks for writeback
> > errors without syncing anything. That would be fairly simple to do and
> > sounds like it would be useful, but I'd want to hear a better
> > description of the use-case before we did anything like that.
> 
> That's what I mean with my above proposal, except that I though of an
> fcntl or syscall and not an ioctl.

Yeah, a fcntl() would be reasonable, I think.

For a syscall, I guess we could add an fsync2() which just adds a flags
field. Then add a FSYNC_JUSTCHECK flag that makes it just check for
errors and return.

Personally, I like the fcntl() idea better for this, but maybe we have
other uses for a fsync2().
-- 
Jeff Layton <jlayton@...nel.org>