linux-kernel - Re: [PATCH v2 2/2] x86/sev: let sev_es_efi_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250625142644.GEaFwHJHFO2gbSN3GJ@fat_crate.local>
Date: Wed, 25 Jun 2025 16:29:36 +0200
From: Borislav Petkov <bp@...en8.de>
To: Gerd Hoffmann <kraxel@...hat.com>
Cc: linux-coco@...ts.linux.dev, kvm@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Ard Biesheuvel <ardb@...nel.org>,
	"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <linux-kernel@...r.kernel.org>,
	"open list:EXTENSIBLE FIRMWARE INTERFACE (EFI)" <linux-efi@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] x86/sev: let sev_es_efi_map_ghcbs map the caa
 pages too

On Wed, Jun 25, 2025 at 03:21:47PM +0200, Gerd Hoffmann wrote:
> This is inside a loop, so returning in case the caa address is NULL will
> skip ghcb setup for all but the first CPU.

Then you should not piggyback on this loop but map the CAs in a separate step,
only when a SVSM is running.

And even then we should think about allowing to continue if not all CAs map
successfully.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette