linux-kernel - Re: [PATCH ath-next 0/2] wifi: ath12k: install pairwise key first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFwOVGGHOHbko9So@hovoldconsulting.com>
Date: Wed, 25 Jun 2025 16:57:24 +0200
From: Johan Hovold <johan@...nel.org>
To: Jeff Johnson <jeff.johnson@....qualcomm.com>
Cc: stable@...r.kernel.org, Jeff Johnson <jjohnson@...nel.org>,
	linux-wireless@...r.kernel.org, ath12k@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Gregoire <gregoire.s93@...e.fr>,
	Sebastian Reichel <sre@...nel.org>,
	Baochen Qiang <quic_bqiang@...cinc.com>
Subject: Re: [PATCH ath-next 0/2] wifi: ath12k: install pairwise key first

On Wed, Jun 25, 2025 at 07:48:54AM -0700, Jeff Johnson wrote:
> On 6/25/2025 3:15 AM, Baochen Qiang wrote:
> > On 6/25/2025 5:51 PM, Johan Hovold wrote:
> >> On Fri, May 23, 2025 at 11:49:00AM +0800, Baochen Qiang wrote:

> >>> We got report that WCN7850 is not working with IWD [1][2]. Debug
> >>> shows the reason is that IWD installs group key before pairwise
> >>> key, which goes against WCN7850's firmware.
> >>>
> >>> Reorder key install to workaround this.
> >>>
> >>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=218733
> >>> [2] https://lore.kernel.org/all/AS8P190MB12051DDBD84CD88E71C40AD7873F2@AS8P190MB1205.EURP190.PROD.OUTLOOK.COM
> >>>
> >>> Signed-off-by: Baochen Qiang <quic_bqiang@...cinc.com>
> >>> ---
> >>> ---
> >>> Baochen Qiang (2):
> >>>       wifi: ath12k: avoid bit operation on key flags
> >>>       wifi: ath12k: install pairwise key first
> >>
> >> Thanks for fixing this, Baochen.
> >>
> >> I noticed the patches weren't clearly marked as fixes. Do you think we
> >> should ask the stable team to backport these once they are in mainline
> >> (e.g. after 6.17-rc1 is out)? Or do you think they are too intrusive and
> >> risky to backport or similar?
> > 
> > Yeah, I think they should be backported.

> +Stable team,
> Per the above discussion please backport the series:
> https://msgid.link/20250523-ath12k-unicast-key-first-v1-0-f53c3880e6d8@quicinc.com

These are currently only in linux-next but would need to be in Linus's
tree before they can be backported, so we'll need to send another
requested once they are in mainline.

> This is a 0-day issue so ideally this should be backported from 6.6+

By "0-day" you mean it has been there since the driver was added, right
(and not that it's exploitable or similar)?

Johan