linux-kernel - Re: [PATCH v5] staging: media: atomisp: fix tab/space issues in output1.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFwSgCtrK7DH3pIw@smile.fi.intel.com>
Date: Wed, 25 Jun 2025 18:15:12 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: LiangCheng Wang <zaq14760@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH v5] staging: media: atomisp: fix tab/space issues in
 output1.0

On Wed, Jun 25, 2025 at 11:04:31PM +0800, LiangCheng Wang wrote:
> Fix indentation style issues by replacing spaces with tabs,
> according to Linux kernel coding style.
> 
> This cleanup improves code readability and follows Linux kernel
> coding standards.
> 
> Signed-off-by: LiangCheng Wang <zaq14760@...il.com>
> ---
> This patch addresses tab/space indentation issues in the
> output_1.0 directory of the AtomISP driver under staging.
> 
> This patch is part of a broader effort to clean up the AtomISP
> driver and is scoped only to tab/space fixes in one directory
> to keep review manageable.
> 
> Further style fixes for other directories and issue types will
> be submitted in subsequent patch revisions or series.
> 
> Fixes were identified using:
> 
> ./scripts/checkpatch.pl -f $(find drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ -type f \( -name "*.c" -o -name "*.h" \))
> grep -Prn '^[ ]+' drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0
> 
> Only lines with space-based indentation (instead of tab) were changed.

> Suggested-by: Andy Shevchenko <andy@...nel.org>
> Link: https://lore.kernel.org/r/CAHp75VeijMvnbrCmRuqTeo_maxevCA9rB-r5URHaX+TrDNvyGA@mail.gmail.com

These two lines should be just above your SoB in the commit message. Currently
they will most likely be ignored (at least by `git am ...`.

...

>  void
>  ia_css_output_encode(
> -    struct sh_css_isp_output_params *to,
> -    const struct ia_css_output_config *from,
> -    unsigned int size)
> +	struct sh_css_isp_output_params *to,
> +	const struct ia_css_output_config *from,
> +	unsigned int size)

In cases like this you might want to also reshuffle the lines:

void ia_css_output_encode(struct sh_css_isp_output_params *to,
			  const struct ia_css_output_config *from,
			  unsigned int size)

...

Have you tried simply to run slang-format against the whole driver using the
clang-format configuration from the kernel source tree?

With it done, you may just make it as a single patch.

-- 
With Best Regards,
Andy Shevchenko