linux-kernel - Re: [PATCH] mm,memory_hotplug: set failure reason in offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2db18566-f864-44f4-bd0b-baa7cc4bebea@redhat.com>
Date: Wed, 25 Jun 2025 17:24:01 +0200
From: David Hildenbrand <david@...hat.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Oscar Salvador <osalvador@...e.de>,
 Andrew Morton <akpm@...ux-foundation.org>, Harry Yoo <harry.yoo@...cle.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Vlastimil Babka <vbabka@...e.cz>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mm,memory_hotplug: set failure reason in offline_pages()

On 25.06.25 17:22, Dan Carpenter wrote:
> The "reason" variable is uninitialized on this error path.  It's supposed
> to explain why the function failed.
> 
> Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   mm/memory_hotplug.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 4d864b4fb891..e954f81b55a0 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1977,8 +1977,10 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages,
>   		node_arg.nid = node;
>   		ret = node_notify(NODE_REMOVING_LAST_MEMORY, &node_arg);
>   		ret = notifier_to_errno(ret);
> -		if (ret)
> +		if (ret) {
> +			reason = "nr_pages more than present_pages";

"node notifier failure"

With that

Acked-by: David Hildenbrand <david@...hat.com>

(likely should be squashed because the commit it might not be stable yet)

-- 
Cheers,

David / dhildenb