linux-kernel - Re: [PULL REQUEST] i2c-for-6.16-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wi+yt71aGSmn4WQjFouxoQuxAmjmM2xO_SD4KipCXjwLw@mail.gmail.com>
Date: Wed, 25 Jun 2025 08:52:57 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <brgl@...ev.pl>, Andi Shyti <andi.shyti@...nel.org>
Subject: Re: [PULL REQUEST] i2c-for-6.16-rc3

On Wed, 25 Jun 2025 at 02:26, Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
>
> I assumed that it was obvious that everything in this pull request was
> automated. I honestly really don't enjoy pushing whitespaces around
> manually.

Actually, the reason I reacted was that it wasn't so very obvious.

I took a look at the commit just because it was larger than expected,
and it didn't look very automated

If you take a look at that commit 614b1c3cbfb0 ("i2c: use inclusive
callbacks in struct i2c_algorithm"), about half looks very
straightforward and looks like a sed-script or something. So you have
things like this:

-       .master_xfer = bit_xfer,
-       .master_xfer_atomic = bit_xfer_atomic,
+       .xfer = bit_xfer,
+       .xfer_atomic = bit_xfer_atomic,

which looks like a very straightforward rename, and may well have been
done with something like

   sed -iE 's/\.master_xfer[[:space:]]*=[[:space:]]*/.xfer = /'

or something like that (same for the 'atomic' version, of course).

But almost half of the lines changed in that patch (ok, 40%) is to
things that didn't actually change. and is just whitespace changes to
unrelated lines that didn't change.

You do mention it in the commit message as "Fix alignment of '=' while
here", but that really did make it much harder to see what was going
on.

And no, this isn't a big deal, but it ended up annoying mainly because
the line count in the pull request was bigger than I would have
expected from the description, which then made me go look at what was
going on...

                Linus