linux-kernel - Re: [PATCH] drm/amdgpu: indent an if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_P1i=GXfmbK4n44UWCLvoyQiwW4UPJFz+Mx4BHqmUbzrg@mail.gmail.com>
Date: Wed, 25 Jun 2025 11:59:42 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Frank Min <Frank.Min@....com>, Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Mario Limonciello <mario.limonciello@....com>, Lijo Lazar <lijo.lazar@....com>, 
	Hawking Zhang <Hawking.Zhang@....com>, Samuel Zhang <guoqing.zhang@....com>, 
	Asad Kamal <asad.kamal@....com>, Ying Li <yingli12@....com>, Prike Liang <Prike.Liang@....com>, 
	Pratap Nirujogi <pratap.nirujogi@....com>, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: indent an if statement

Applied.  Thanks!

Alex

On Wed, Jun 25, 2025 at 11:38 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The "return true;" line wasn't indented.  Also checkpatch likes when
> we align the && conditions.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> index d777c049747e..a0b50a8ac9c4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -1400,8 +1400,8 @@ bool amdgpu_is_kicker_fw(struct amdgpu_device *adev)
>
>         for (i = 0; i < ARRAY_SIZE(kicker_device_list); i++) {
>                 if (adev->pdev->device == kicker_device_list[i].device &&
> -                       adev->pdev->revision == kicker_device_list[i].revision)
> -               return true;
> +                   adev->pdev->revision == kicker_device_list[i].revision)
> +                       return true;
>         }
>
>         return false;
> --
> 2.47.2
>