linux-kernel - Re: [patch V2 00/13] ptp: Belated spring cleaning of the chardev driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a55vrelj.ffs@tglx>
Date: Wed, 25 Jun 2025 18:05:44 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Richard Cochran <richardcochran@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, Vadim
 Fedorenko <vadim.fedorenko@...ux.dev>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>
Subject: Re: [patch V2 00/13] ptp: Belated spring cleaning of the chardev
 driver

On Wed, Jun 25 2025 at 07:40, Richard Cochran wrote:

> On Wed, Jun 25, 2025 at 01:52:23PM +0200, Thomas Gleixner wrote:
>> The code (~400 lines!) is really hard to follow due to a gazillion of
>> local variables, which are only used in certain case scopes, and a
>> mixture of gotos, breaks and direct error return paths.
>
> But it is 100% organically grown and therefore healthy for you!

You sure there were no forbidden plants involved?