linux-kernel - Re: [PATCH v6 10/25] iommufd/viommu: Add IOMMUFD_CMD_HW_QUEUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFwenQwrKz8rHY9T@Asurada-Nvidia>
Date: Wed, 25 Jun 2025 09:06:53 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: "Tian, Kevin" <kevin.tian@...el.com>
CC: Baolu Lu <baolu.lu@...ux.intel.com>, "jgg@...dia.com" <jgg@...dia.com>,
	"corbet@....net" <corbet@....net>, "will@...nel.org" <will@...nel.org>,
	"bagasdotme@...il.com" <bagasdotme@...il.com>, "robin.murphy@....com"
	<robin.murphy@....com>, "joro@...tes.org" <joro@...tes.org>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>, "vdumpa@...dia.com"
	<vdumpa@...dia.com>, "jonathanh@...dia.com" <jonathanh@...dia.com>,
	"shuah@...nel.org" <shuah@...nel.org>, "jsnitsel@...hat.com"
	<jsnitsel@...hat.com>, "nathan@...nel.org" <nathan@...nel.org>,
	"peterz@...radead.org" <peterz@...radead.org>, "Liu, Yi L"
	<yi.l.liu@...el.com>, "mshavit@...gle.com" <mshavit@...gle.com>,
	"praan@...gle.com" <praan@...gle.com>, "zhangzekun11@...wei.com"
	<zhangzekun11@...wei.com>, "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>, "mochs@...dia.com" <mochs@...dia.com>,
	"alok.a.tiwari@...cle.com" <alok.a.tiwari@...cle.com>, "vasant.hegde@....com"
	<vasant.hegde@....com>, "dwmw2@...radead.org" <dwmw2@...radead.org>
Subject: Re: [PATCH v6 10/25] iommufd/viommu: Add IOMMUFD_CMD_HW_QUEUE_ALLOC
 ioctl

On Wed, Jun 25, 2025 at 03:43:08AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@...dia.com>
> > Sent: Monday, June 16, 2025 2:47 PM
> > > Leave other logics to the patches that introduce
> > > ops->hw_queue_init? I guess that would make this patch more readible.
> > 
> > The patch is doing in the way to support the hw_queue_init_phys
> > case only. It is just adding some extra FIXMEs as the guideline
> > for the future patch adding hw_queue_init op.
> > 
> > I personally don't feel these are confusing. Maybe you can help
> > point out what specific wording feels odd here? Maybe "FIXME"s
> > should be "TODO"s?
> > 
> > I could also drop all of these guideline if they are considered
> > very unnecessary.
> > 
> 
> Probably you can put some info in the function comment instead
> of being scattered in the code? anyway when the 2nd method
> is added in future we'll review and make sure it aligned with the
> caveat here. 😊

Yea, probably can drop them. I think AMD will figure it out easily :)

Thanks
Nicolin