linux-kernel - Re: [PATCH v14 08/32] x86,fs/resctrl: Consolidate monitoring related data from rdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6484f9c4-894d-40f3-937c-ccbd6adef61b@amd.com>
Date: Wed, 25 Jun 2025 11:53:24 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
 tony.luck@...el.com, Dave.Martin@....com, james.morse@....com,
 tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: x86@...nel.org, hpa@...or.com, akpm@...ux-foundation.org,
 rostedt@...dmis.org, paulmck@...nel.org, thuth@...hat.com, ardb@...nel.org,
 gregkh@...uxfoundation.org, seanjc@...gle.com, thomas.lendacky@....com,
 pawan.kumar.gupta@...ux.intel.com, manali.shukla@....com,
 perry.yuan@....com, kai.huang@...el.com, peterz@...radead.org,
 xiaoyao.li@...el.com, kan.liang@...ux.intel.com, mario.limonciello@....com,
 xin3.li@...el.com, gautham.shenoy@....com, xin@...or.com,
 chang.seok.bae@...el.com, fenghuay@...dia.com, peternewman@...gle.com,
 maciej.wieczor-retman@...el.com, eranian@...gle.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v14 08/32] x86,fs/resctrl: Consolidate monitoring related
 data from rdt_resource

Hi Reinette,

On 6/24/25 16:32, Reinette Chatre wrote:
> Hi Babu,
> 
> On 6/13/25 2:04 PM, Babu Moger wrote:
> 
> ...
> 
>> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
>> index bbe57eff962b..22766b8b670b 100644
>> --- a/include/linux/resctrl.h
>> +++ b/include/linux/resctrl.h
>> @@ -255,38 +255,46 @@ enum resctrl_schema_fmt {
>>  	RESCTRL_SCHEMA_RANGE,
>>  };
>>  
>> +/**
>> + * struct resctrl_mon - Monitoring related data of a resctrl resource.
>> + * @num_rmid:		Number of RMIDs available.
>> + * @mbm_cfg_mask:	Memory transactions that can be tracked when bandwidth
>> + *			monitoring events are configured.
> 
> "are configured" -> "can be configured" (like it was before). This is a property
> that is discovered from hardware. The feature need not be in use for the property
> to be valid.

Sure.


> Also, this version switches "Bandwidth sources" -> "Memory transactions". I think this
> is a good change but it may be unexpected. Perhaps a snippet in changelog to
> point out the motivation for this change: "Also switch "bandwidth sources" term
> to "memory transactions" to use consistent term within resctrl for related monitoring
> features". Please feel free to improve.
> 

Sure. This is how it looks now.

"The cache allocation and memory bandwidth allocation feature properties
are consolidated into struct resctrl_cache and struct resctrl_membw
respectively.

In preparation for more monitoring properties that will clobber the
existing resource struct more, re-organize the monitoring specific
properties to also be in a separate structure.

Also switch "bandwidth sources" term to "memory transactions" to use
consistent term within resctrl for related monitoring features."

-- 
Thanks
Babu Moger