linux-kernel - Re: [PATCH] leds: tps6131x: add V4L2_FLASH_LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e99773dd-c49e-4a09-bf2c-dacadfdd1c5b@infradead.org>
Date: Tue, 24 Jun 2025 21:02:25 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Arnd Bergmann <arnd@...nel.org>, Lee Jones <lee@...nel.org>,
 Pavel Machek <pavel@...nel.org>, Matthias Fend <matthias.fend@...end.at>
Cc: Arnd Bergmann <arnd@...db.de>, André Apitzsch
 <git@...tzsch.eu>, linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: tps6131x: add V4L2_FLASH_LED_CLASS dependency



On 6/20/25 4:43 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This driver can optionally use the v4l2_flash infrastructure, but fails to
> link built=in if that is in a loadable module:
> 
> ld.lld-21: error: undefined symbol: v4l2_flash_release
>>>> referenced by leds-tps6131x.c:792 (drivers/leds/flash/leds-tps6131x.c:792)
> 
> Add the usual Kconfig dependency for it, still allowing it to be built when
> CONFIG_V4L2_FLASH_LED_CLASS is disabled.
> 
> Fixes: b338a2ae9b31 ("leds: tps6131x: Add support for Texas Instruments TPS6131X flash LED driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I just made this same patch, so

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/leds/flash/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig
> index 55ca663ca506..5e08102a6784 100644
> --- a/drivers/leds/flash/Kconfig
> +++ b/drivers/leds/flash/Kconfig
> @@ -136,6 +136,7 @@ config LEDS_TPS6131X
>  	tristate "LED support for TI TPS6131x flash LED driver"
>  	depends on I2C && OF
>  	depends on GPIOLIB
> +	depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
>  	select REGMAP_I2C
>  	help
>  	  This option enables support for Texas Instruments TPS61310/TPS61311

-- 
~Randy