linux-kernel - RE: [PATCH] wifi: iwlwifi: pcie: unlock on error in iwl_trans_pcie_gen2_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM3PPF63A6024A9A97D5A9836F92CFD9B98A37BA@DM3PPF63A6024A9.namprd11.prod.outlook.com>
Date: Wed, 25 Jun 2025 17:44:56 +0000
From: "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: "Berg, Johannes" <johannes.berg@...el.com>, "Grumbach, Emmanuel"
	<emmanuel.grumbach@...el.com>, "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] wifi: iwlwifi: pcie: unlock on error in
 iwl_trans_pcie_gen2_start_fw()

> Subject: [PATCH] wifi: iwlwifi: pcie: unlock on error in
> iwl_trans_pcie_gen2_start_fw()
> 
> We need to call mutex_unlock(&trans_pcie->mutex) before returning on this
> error path.
> 
> Fixes: aeee73e27f2d ("wifi: iwlwifi: pcie: move generation specific files to a
> folder")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans-gen2.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans-gen2.c
> b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans-gen2.c
> index 0df8522ca410..8ff23f3931c6 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans-gen2.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans-gen2.c
> @@ -546,8 +546,10 @@ int iwl_trans_pcie_gen2_start_fw(struct iwl_trans
> *trans,
>  	}
> 
>  	if (WARN_ON(trans->do_top_reset &&
> -		    trans->mac_cfg->device_family < IWL_DEVICE_FAMILY_SC))
> -		return -EINVAL;
> +		    trans->mac_cfg->device_family < IWL_DEVICE_FAMILY_SC))
> {
> +		ret = -EINVAL;
> +		goto out;
> +	}
> 
>  	/* we need to wait later - set state */
>  	if (trans->do_top_reset)
> --
> 2.47.2

Hi Dan,

Thanks for your patch, but we already have such a patch internally,
which will be sent soon.

Miri