linux-kernel - Re: [PATCH v3 12/16] cifs: Fix reading into an ITER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1425470.1750877586@warthog.procyon.org.uk>
Date: Wed, 25 Jun 2025 19:53:06 +0100
From: David Howells <dhowells@...hat.com>
To: Tom Talpey <tom@...pey.com>
Cc: dhowells@...hat.com, Stefan Metzmacher <metze@...ba.org>,
    Christian Brauner <christian@...uner.io>,
    Steve French <sfrench@...ba.org>, Paulo Alcantara <pc@...guebit.com>,
    netfs@...ts.linux.dev, linux-afs@...ts.infradead.org,
    linux-cifs@...r.kernel.org, linux-nfs@...r.kernel.org,
    ceph-devel@...r.kernel.org, v9fs@...ts.linux.dev,
    linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
    Steve French <stfrench@...rosoft.com>,
    Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v3 12/16] cifs: Fix reading into an ITER_FOLIOQ from the smbdirect code

Tom Talpey <tom@...pey.com> wrote:

> 
> Shouldn't there be some kind of validity check on the rfc1002 length
> field before this? For example, the high octet of that field is
> required to be zero (by SMB) and the 24-bit length is not necessarily
> checked yet. The original code just returned the decoded value but
> this sticks it in the msg_iter. If that's safe, then ok but it seems
> odd.

That should be a separate bugfix, I think.

David