linux-kernel - Re: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFxGdIceR2DeG07K@lg>
Date: Wed, 25 Jun 2025 11:56:52 -0700
From: Fan Ni <nifan.cxl@...il.com>
To: Li Ming <ming.li@...omail.com>
Cc: dave@...olabs.net, jonathan.cameron@...wei.com, dave.jiang@...el.com,
	alison.schofield@...el.com, vishal.l.verma@...el.com,
	ira.weiny@...el.com, dan.j.williams@...el.com,
	shiju.jose@...wei.com, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram
 event record

On Fri, Jun 20, 2025 at 01:29:24PM +0800, Li Ming wrote:
> cxl_find_rec_dram() is used to find a DRAM event record based on the
> inputted attributes. Different repair_type of the inputted attributes
> will check the DRAM event record in different ways.
> When EDAC driver is performing a memory rank sparing, it should use
> CXL_RANK_SPARING rather than CXL_BANK_SPARING as repair_type for DRAM
> event record checking.
> 
> Fixes: 588ca944c277 ("cxl/edac: Add CXL memory device memory sparing control feature")
> Signed-off-by: Li Ming <ming.li@...omail.com>
> ---

Reviewed-by: Fan Ni <fan.ni@...sung.com>

> base-commit: 3c70ec71abdaf4e4fa48cd8fdfbbd864d78235a8 cxl/fixes
> ---
>  drivers/cxl/core/edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/edac.c b/drivers/cxl/core/edac.c
> index d725ee954199..623aaa4439c4 100644
> --- a/drivers/cxl/core/edac.c
> +++ b/drivers/cxl/core/edac.c
> @@ -1323,7 +1323,7 @@ cxl_mem_get_rec_dram(struct cxl_memdev *cxlmd,
>  		attrbs.bank = ctx->bank;
>  	break;
>  	case EDAC_REPAIR_RANK_SPARING:
> -		attrbs.repair_type = CXL_BANK_SPARING;
> +		attrbs.repair_type = CXL_RANK_SPARING;
>  		break;
>  	default:
>  		return NULL;
> -- 
> 2.34.1
> 

-- 
Fan Ni