| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aFxNx8250L1bBaC9@x1> Date: Wed, 25 Jun 2025 16:28:07 -0300 From: Arnaldo Carvalho de Melo <acme@...nel.org> To: James Clark <james.clark@...aro.org> Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, Suzuki K Poulose <suzuki.poulose@....com>, Mike Leach <mike.leach@...aro.org>, Nick Terrell <terrelln@...com>, David Sterba <dsterba@...e.com>, Collin Funk <collin.funk1@...il.com>, linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org, bpf@...r.kernel.org Subject: Re: [PATCH] perf test: Change all remaining #!/bin/sh to #!/bin/bash On Mon, Jun 23, 2025 at 10:00:12AM +0100, James Clark wrote: > There are 43 instances of posix shell tests and 35 instances of bash. To > give us a single consistent language for testing in, replace > all #!/bin/sh to #!/bin/bash. Common sources that are included in both > different shells will now work as expected. And we no longer have to fix > up bashisms that appear to work when someone's system has sh symlinked > to bash, but don't work on other systems that have both shells > installed. > > Although we could have chosen sh, it's not backwards compatible so it > wouldn't be possible to bulk convert without re-writing the existing > bash tests. > > Choosing bash also gives us some nicer features including 'local' > variable definitions and regexes in if statements that are already > widely used in the tests. > > It's not expected that there are any users with only sh available due to > the large number of bash tests that exist. > > Discussed in relation to running shellcheck here: > https://lore.kernel.org/linux-perf-users/e3751a74be34bbf3781c4644f518702a7270220b.1749785642.git.collin.funk1@gmail.com/ The reasoning is sound, agreed: Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com> - Arnaldo > Signed-off-by: James Clark <james.clark@...aro.org> > --- > tools/perf/tests/perf-targz-src-pkg | 2 +- > tools/perf/tests/shell/amd-ibs-swfilt.sh | 2 +- > tools/perf/tests/shell/buildid.sh | 2 +- > tools/perf/tests/shell/coresight/asm_pure_loop.sh | 2 +- > tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh | 2 +- > tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh | 2 +- > tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh | 2 +- > tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh | 2 +- > tools/perf/tests/shell/diff.sh | 2 +- > tools/perf/tests/shell/ftrace.sh | 2 +- > tools/perf/tests/shell/lib/perf_has_symbol.sh | 2 +- > tools/perf/tests/shell/lib/probe_vfs_getname.sh | 2 +- > tools/perf/tests/shell/lib/setup_python.sh | 2 +- > tools/perf/tests/shell/lib/waiting.sh | 2 +- > tools/perf/tests/shell/list.sh | 2 +- > tools/perf/tests/shell/lock_contention.sh | 2 +- > tools/perf/tests/shell/perf-report-hierarchy.sh | 2 +- > tools/perf/tests/shell/probe_vfs_getname.sh | 2 +- > tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 +- > tools/perf/tests/shell/record+script_probe_vfs_getname.sh | 2 +- > tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +- > tools/perf/tests/shell/record_bpf_filter.sh | 2 +- > tools/perf/tests/shell/record_offcpu.sh | 2 +- > tools/perf/tests/shell/record_sideband.sh | 2 +- > tools/perf/tests/shell/script.sh | 2 +- > tools/perf/tests/shell/stat+csv_summary.sh | 2 +- > tools/perf/tests/shell/stat+shadow_stat.sh | 2 +- > tools/perf/tests/shell/stat_all_pfm.sh | 2 +- > tools/perf/tests/shell/stat_bpf_counters.sh | 2 +- > tools/perf/tests/shell/stat_bpf_counters_cgrp.sh | 2 +- > tools/perf/tests/shell/test_arm_callgraph_fp.sh | 2 +- > tools/perf/tests/shell/test_arm_coresight.sh | 2 +- > tools/perf/tests/shell/test_arm_coresight_disasm.sh | 2 +- > tools/perf/tests/shell/test_arm_spe.sh | 2 +- > tools/perf/tests/shell/test_arm_spe_fork.sh | 2 +- > tools/perf/tests/shell/test_bpf_metadata.sh | 2 +- > tools/perf/tests/shell/test_intel_pt.sh | 2 +- > tools/perf/tests/shell/trace+probe_vfs_getname.sh | 2 +- > tools/perf/tests/shell/trace_btf_enum.sh | 2 +- > tools/perf/tests/shell/trace_exit_race.sh | 2 +- > tools/perf/tests/shell/trace_record_replay.sh | 2 +- > tools/perf/tests/shell/trace_summary.sh | 2 +- > tools/perf/tests/tests-scripts.c | 2 +- > 43 files changed, 43 insertions(+), 43 deletions(-) > > diff --git a/tools/perf/tests/perf-targz-src-pkg b/tools/perf/tests/perf-targz-src-pkg > index b3075c168cb2..52a90e6bd8af 100755 > --- a/tools/perf/tests/perf-targz-src-pkg > +++ b/tools/perf/tests/perf-targz-src-pkg > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # SPDX-License-Identifier: GPL-2.0 > # Test one of the main kernel Makefile targets to generate a perf sources tarball > # suitable for build outside the full kernel sources. > diff --git a/tools/perf/tests/shell/amd-ibs-swfilt.sh b/tools/perf/tests/shell/amd-ibs-swfilt.sh > index 83937aa687cc..7045ec72ba4c 100755 > --- a/tools/perf/tests/shell/amd-ibs-swfilt.sh > +++ b/tools/perf/tests/shell/amd-ibs-swfilt.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # AMD IBS software filtering > > echo "check availability of IBS swfilt" > diff --git a/tools/perf/tests/shell/buildid.sh b/tools/perf/tests/shell/buildid.sh > index 3383ca3399d4..d2eb213da01d 100755 > --- a/tools/perf/tests/shell/buildid.sh > +++ b/tools/perf/tests/shell/buildid.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # build id cache operations > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/coresight/asm_pure_loop.sh b/tools/perf/tests/shell/coresight/asm_pure_loop.sh > index c63bc8c73e26..0301904b9637 100755 > --- a/tools/perf/tests/shell/coresight/asm_pure_loop.sh > +++ b/tools/perf/tests/shell/coresight/asm_pure_loop.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh -e > +#!/bin/bash -e > # CoreSight / ASM Pure Loop (exclusive) > > # SPDX-License-Identifier: GPL-2.0 > diff --git a/tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh b/tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh > index 8e29630957c8..1f765d69acc3 100755 > --- a/tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh > +++ b/tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh -e > +#!/bin/bash -e > # CoreSight / Memcpy 16k 10 Threads (exclusive) > > # SPDX-License-Identifier: GPL-2.0 > diff --git a/tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh b/tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh > index 0c4c82a1c8e1..7f43a93a2ac2 100755 > --- a/tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh > +++ b/tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh -e > +#!/bin/bash -e > # CoreSight / Thread Loop 10 Threads - Check TID (exclusive) > > # SPDX-License-Identifier: GPL-2.0 > diff --git a/tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh b/tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh > index d3aea9fc6ced..a94d2079ed06 100755 > --- a/tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh > +++ b/tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh -e > +#!/bin/bash -e > # CoreSight / Thread Loop 2 Threads - Check TID (exclusive) > > # SPDX-License-Identifier: GPL-2.0 > diff --git a/tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh b/tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh > index 7429d3a2ae43..cb3e97a0a89f 100755 > --- a/tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh > +++ b/tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh -e > +#!/bin/bash -e > # CoreSight / Unroll Loop Thread 10 (exclusive) > > # SPDX-License-Identifier: GPL-2.0 > diff --git a/tools/perf/tests/shell/diff.sh b/tools/perf/tests/shell/diff.sh > index e05a5dc49479..fe05fdebcab5 100755 > --- a/tools/perf/tests/shell/diff.sh > +++ b/tools/perf/tests/shell/diff.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf diff tests > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/ftrace.sh b/tools/perf/tests/shell/ftrace.sh > index c243731d2fbf..7f8aafcbb761 100755 > --- a/tools/perf/tests/shell/ftrace.sh > +++ b/tools/perf/tests/shell/ftrace.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf ftrace tests > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/lib/perf_has_symbol.sh b/tools/perf/tests/shell/lib/perf_has_symbol.sh > index 561c93b75d77..0b35cce0b13d 100644 > --- a/tools/perf/tests/shell/lib/perf_has_symbol.sh > +++ b/tools/perf/tests/shell/lib/perf_has_symbol.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # SPDX-License-Identifier: GPL-2.0 > > perf_has_symbol() > diff --git a/tools/perf/tests/shell/lib/probe_vfs_getname.sh b/tools/perf/tests/shell/lib/probe_vfs_getname.sh > index 58debce9ab42..88cd0e26d5f6 100644 > --- a/tools/perf/tests/shell/lib/probe_vfs_getname.sh > +++ b/tools/perf/tests/shell/lib/probe_vfs_getname.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Arnaldo Carvalho de Melo <acme@...nel.org>, 2017 > > perf probe -l 2>&1 | grep -q probe:vfs_getname > diff --git a/tools/perf/tests/shell/lib/setup_python.sh b/tools/perf/tests/shell/lib/setup_python.sh > index c2fce1793538..a58e5536f2ed 100644 > --- a/tools/perf/tests/shell/lib/setup_python.sh > +++ b/tools/perf/tests/shell/lib/setup_python.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # SPDX-License-Identifier: GPL-2.0 > > if [ "x$PYTHON" = "x" ] > diff --git a/tools/perf/tests/shell/lib/waiting.sh b/tools/perf/tests/shell/lib/waiting.sh > index bdd5a7c71591..3a152892e077 100644 > --- a/tools/perf/tests/shell/lib/waiting.sh > +++ b/tools/perf/tests/shell/lib/waiting.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # SPDX-License-Identifier: GPL-2.0 > > tenths=date\ +%s%1N > diff --git a/tools/perf/tests/shell/list.sh b/tools/perf/tests/shell/list.sh > index 76a9846cff22..0c04b3159cef 100755 > --- a/tools/perf/tests/shell/list.sh > +++ b/tools/perf/tests/shell/list.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf list tests > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/lock_contention.sh b/tools/perf/tests/shell/lock_contention.sh > index 30d195d4c62f..dde5bc737eb2 100755 > --- a/tools/perf/tests/shell/lock_contention.sh > +++ b/tools/perf/tests/shell/lock_contention.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # kernel lock contention analysis test > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/perf-report-hierarchy.sh b/tools/perf/tests/shell/perf-report-hierarchy.sh > index 02e3b6aee4ed..e3c6f9a24f33 100755 > --- a/tools/perf/tests/shell/perf-report-hierarchy.sh > +++ b/tools/perf/tests/shell/perf-report-hierarchy.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf report --hierarchy > # SPDX-License-Identifier: GPL-2.0 > # Arnaldo Carvalho de Melo <acme@...hat.com> > diff --git a/tools/perf/tests/shell/probe_vfs_getname.sh b/tools/perf/tests/shell/probe_vfs_getname.sh > index 0f52654c914a..5fe5682c28ce 100755 > --- a/tools/perf/tests/shell/probe_vfs_getname.sh > +++ b/tools/perf/tests/shell/probe_vfs_getname.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Add vfs_getname probe to get syscall args filenames (exclusive) > > # SPDX-License-Identifier: GPL-2.0 > diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh > index c4bab5b5cc59..cfad1bd7b780 100755 > --- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh > +++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # probe libc's inet_pton & backtrace it with ping (exclusive) > > # Installs a probe on libc's inet_pton function, that will use uprobes, > diff --git a/tools/perf/tests/shell/record+script_probe_vfs_getname.sh b/tools/perf/tests/shell/record+script_probe_vfs_getname.sh > index 1ad252f0d36e..002f7037f182 100755 > --- a/tools/perf/tests/shell/record+script_probe_vfs_getname.sh > +++ b/tools/perf/tests/shell/record+script_probe_vfs_getname.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Use vfs_getname probe to get syscall args filenames (exclusive) > > # Uses the 'perf test shell' library to add probe:vfs_getname to the system > diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh > index 8929046e9057..f6b82223834e 100755 > --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh > +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Zstd perf.data compression/decompression > > # SPDX-License-Identifier: GPL-2.0 > diff --git a/tools/perf/tests/shell/record_bpf_filter.sh b/tools/perf/tests/shell/record_bpf_filter.sh > index 4d6c3c1b7fb9..383574cb3bd3 100755 > --- a/tools/perf/tests/shell/record_bpf_filter.sh > +++ b/tools/perf/tests/shell/record_bpf_filter.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf record sample filtering (by BPF) tests > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh > index 21a22efe08f5..860a2d6f4b75 100755 > --- a/tools/perf/tests/shell/record_offcpu.sh > +++ b/tools/perf/tests/shell/record_offcpu.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf record offcpu profiling tests (exclusive) > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/record_sideband.sh b/tools/perf/tests/shell/record_sideband.sh > index ac70ac27d590..2182551873be 100755 > --- a/tools/perf/tests/shell/record_sideband.sh > +++ b/tools/perf/tests/shell/record_sideband.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf record sideband tests > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/script.sh b/tools/perf/tests/shell/script.sh > index d3e2958d2242..7007f1cdf761 100755 > --- a/tools/perf/tests/shell/script.sh > +++ b/tools/perf/tests/shell/script.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf script tests > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/stat+csv_summary.sh b/tools/perf/tests/shell/stat+csv_summary.sh > index 323123ff4d19..9a4353db3825 100755 > --- a/tools/perf/tests/shell/stat+csv_summary.sh > +++ b/tools/perf/tests/shell/stat+csv_summary.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf stat csv summary test > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/stat+shadow_stat.sh b/tools/perf/tests/shell/stat+shadow_stat.sh > index 0c7d79a230ea..8824f445d343 100755 > --- a/tools/perf/tests/shell/stat+shadow_stat.sh > +++ b/tools/perf/tests/shell/stat+shadow_stat.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf stat metrics (shadow stat) test > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/stat_all_pfm.sh b/tools/perf/tests/shell/stat_all_pfm.sh > index 4d004f777a6e..c08c186af2c4 100755 > --- a/tools/perf/tests/shell/stat_all_pfm.sh > +++ b/tools/perf/tests/shell/stat_all_pfm.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf all libpfm4 events test > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/stat_bpf_counters.sh b/tools/perf/tests/shell/stat_bpf_counters.sh > index 95d2ad5d17c6..f43e28a136d3 100755 > --- a/tools/perf/tests/shell/stat_bpf_counters.sh > +++ b/tools/perf/tests/shell/stat_bpf_counters.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf stat --bpf-counters test (exclusive) > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/stat_bpf_counters_cgrp.sh b/tools/perf/tests/shell/stat_bpf_counters_cgrp.sh > index 2ec69060c42f..ff2e06c408bc 100755 > --- a/tools/perf/tests/shell/stat_bpf_counters_cgrp.sh > +++ b/tools/perf/tests/shell/stat_bpf_counters_cgrp.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf stat --bpf-counters --for-each-cgroup test > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/test_arm_callgraph_fp.sh b/tools/perf/tests/shell/test_arm_callgraph_fp.sh > index 9caa36130175..9172dd68a81d 100755 > --- a/tools/perf/tests/shell/test_arm_callgraph_fp.sh > +++ b/tools/perf/tests/shell/test_arm_callgraph_fp.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Check Arm64 callgraphs are complete in fp mode > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh > index 573af9235b72..1c750b67d141 100755 > --- a/tools/perf/tests/shell/test_arm_coresight.sh > +++ b/tools/perf/tests/shell/test_arm_coresight.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Check Arm CoreSight trace data recording and synthesized samples (exclusive) > > # Uses the 'perf record' to record trace data with Arm CoreSight sinks; > diff --git a/tools/perf/tests/shell/test_arm_coresight_disasm.sh b/tools/perf/tests/shell/test_arm_coresight_disasm.sh > index be2d26303f94..0dfb4fadf531 100755 > --- a/tools/perf/tests/shell/test_arm_coresight_disasm.sh > +++ b/tools/perf/tests/shell/test_arm_coresight_disasm.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Check Arm CoreSight disassembly script completes without errors (exclusive) > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/test_arm_spe.sh b/tools/perf/tests/shell/test_arm_spe.sh > index a69aab70dd8a..bb76ea88aa14 100755 > --- a/tools/perf/tests/shell/test_arm_spe.sh > +++ b/tools/perf/tests/shell/test_arm_spe.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Check Arm SPE trace data recording and synthesized samples (exclusive) > > # Uses the 'perf record' to record trace data of Arm SPE events; > diff --git a/tools/perf/tests/shell/test_arm_spe_fork.sh b/tools/perf/tests/shell/test_arm_spe_fork.sh > index 8efeef9fb956..5bcca51c03ac 100755 > --- a/tools/perf/tests/shell/test_arm_spe_fork.sh > +++ b/tools/perf/tests/shell/test_arm_spe_fork.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Check Arm SPE doesn't hang when there are forks > > # SPDX-License-Identifier: GPL-2.0 > diff --git a/tools/perf/tests/shell/test_bpf_metadata.sh b/tools/perf/tests/shell/test_bpf_metadata.sh > index 11df592fb661..bc9aef161664 100755 > --- a/tools/perf/tests/shell/test_bpf_metadata.sh > +++ b/tools/perf/tests/shell/test_bpf_metadata.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # SPDX-License-Identifier: GPL-2.0 > # > # BPF metadata collection test. > diff --git a/tools/perf/tests/shell/test_intel_pt.sh b/tools/perf/tests/shell/test_intel_pt.sh > index 32a9b8dcb200..8ee761f03c38 100755 > --- a/tools/perf/tests/shell/test_intel_pt.sh > +++ b/tools/perf/tests/shell/test_intel_pt.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Miscellaneous Intel PT testing (exclusive) > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/trace+probe_vfs_getname.sh b/tools/perf/tests/shell/trace+probe_vfs_getname.sh > index 5d5019988d61..7a0b1145d0cd 100755 > --- a/tools/perf/tests/shell/trace+probe_vfs_getname.sh > +++ b/tools/perf/tests/shell/trace+probe_vfs_getname.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # Check open filename arg using perf trace + vfs_getname (exclusive) > > # Uses the 'perf test shell' library to add probe:vfs_getname to the system > diff --git a/tools/perf/tests/shell/trace_btf_enum.sh b/tools/perf/tests/shell/trace_btf_enum.sh > index c37017bfeb5e..572001d75d78 100755 > --- a/tools/perf/tests/shell/trace_btf_enum.sh > +++ b/tools/perf/tests/shell/trace_btf_enum.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf trace enum augmentation tests > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/trace_exit_race.sh b/tools/perf/tests/shell/trace_exit_race.sh > index 1e247693e756..db300cde94fb 100755 > --- a/tools/perf/tests/shell/trace_exit_race.sh > +++ b/tools/perf/tests/shell/trace_exit_race.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf trace exit race > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/trace_record_replay.sh b/tools/perf/tests/shell/trace_record_replay.sh > index 6b4ed863c1ef..88d30a03dcec 100755 > --- a/tools/perf/tests/shell/trace_record_replay.sh > +++ b/tools/perf/tests/shell/trace_record_replay.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf trace record and replay > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/shell/trace_summary.sh b/tools/perf/tests/shell/trace_summary.sh > index f9bb7f9388be..22e2651d5919 100755 > --- a/tools/perf/tests/shell/trace_summary.sh > +++ b/tools/perf/tests/shell/trace_summary.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > +#!/bin/bash > # perf trace summary (exclusive) > # SPDX-License-Identifier: GPL-2.0 > > diff --git a/tools/perf/tests/tests-scripts.c b/tools/perf/tests/tests-scripts.c > index 1d5759d08141..684feed58254 100644 > --- a/tools/perf/tests/tests-scripts.c > +++ b/tools/perf/tests/tests-scripts.c > @@ -85,7 +85,7 @@ static char *shell_test__description(int dir_fd, const char *name) > if (io.fd < 0) > return NULL; > > - /* Skip first line - should be #!/bin/sh Shebang */ > + /* Skip first line - should be #!/bin/bash Shebang */ > if (io__get_char(&io) != '#') > goto err_out; > if (io__get_char(&io) != '!') > > --- > base-commit: edf2cadf01e8f2620af25b337d15ebc584911b46 > change-id: 20250623-james-perf-bash-tests-88261a847552 > > Best regards, > -- > James Clark <james.clark@...aro.org>
Powered by blists - more mailing lists