linux-kernel - Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250625194453.GA2093083-robh@kernel.org>
Date: Wed, 25 Jun 2025 14:44:53 -0500
From: Rob Herring <robh@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Andrew Davis <afd@...com>, Tony Lindgren <tony@...mide.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Andreas Kemnade <andreas@...nade.info>,
	Kevin Hilman <khilman@...libre.com>,
	Roger Quadros <rogerq@...nel.org>,
	Russell King <linux@...linux.org.uk>,
	Bajjuri Praneeth <praneeth@...com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33
 compatibles

On Tue, Jun 10, 2025 at 10:05:44AM +0200, Kory Maincent wrote:
> Le Mon, 9 Jun 2025 18:34:10 -0500,
> Andrew Davis <afd@...com> a écrit :
> 
> > On 6/9/25 10:43 AM, Kory Maincent wrote:
> > > Add several compatible strings that were missing from the binding
> > > documentation. Add description for Bone, BoneBlack and BoneGreen
> > > variants.
> > > 
> > > Add several compatible that were missing from the binding.
> > > 
> > > Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> > > ---
> > > 
> > > Change in v2:
> > > - New patch
> > > ---
> > >   Documentation/devicetree/bindings/arm/ti/omap.yaml | 38
> > > ++++++++++++++++++++++ 1 file changed, 38 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > > 3603edd7361d..c43fa4f4af81 100644 ---
> > > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -104,12 +104,50 @@
> > > properties:
> > >         - description: TI AM33 based platform
> > >           items:
> > >             - enum:
> > > +              - bosch,am335x-guardian
> > >                 - compulab,cm-t335
> > > +              - grinn,am335x-chilisom
> > > +              - gumstix,am335x-pepper
> > > +              - moxa,uc-2101
> > >                 - moxa,uc-8100-me-t
> > > +              - myir,myc-am335x
> > > +              - myir,myd-am335x
> > >                 - novatech,am335x-lxm
> > > +              - oct,osd3358-sm-refdesign
> > > +              - tcl,am335x-sl50
> > >                 - ti,am335x-bone
> > >                 - ti,am335x-evm
> > > +              - ti,am335x-evmsk
> > > +              - ti,am335x-pocketbeagle
> > > +              - ti,am335x-shc
> > >                 - ti,am3359-icev2
> > > +              - vscom,onrisc
> > > +          - const: ti,am33xx
> > > +
> > > +      - description: TI bone variants based on TI AM335  
> > 
> > Do we really need these "bone variants" split out from the above
> > list of TI AM33 based boards? We don't do that for any of the other
> > boards, you get a SoC and a Board compatible, every classification
> > in-between is just unneeded.
> 
> As omap maintainers prefer. I did that to have the least amount of change in
> the devicetree. We could have U-boot using these compatible but after a quick
> check it seems not.

I agree with both. The intermediate compatibles that TI in particular 
went crazy on have proven to be not useful. However, between having to 
fix existing .dts files and keeping them, I would just keep them.

Rob