linux-kernel - Re: [PATCH v3] staging: media: atomisp: remove debug sysfs attributes active_bo and free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGn2d8NmM3Jr+ZR=hj6KYyHdkx1Vc0-Q2RE7Y2o9RfQM1dPAog@mail.gmail.com>
Date: Wed, 25 Jun 2025 23:07:34 +0300
From: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: andy@...nel.org, hdegoede@...hat.com, mchehab@...nel.org, 
	sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org, 
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev, skhan@...uxfoundation.org, 
	linux-kernel-mentees@...ts.linux.dev, dan.carpenter@...aro.org
Subject: Re: [PATCH v3] staging: media: atomisp: remove debug sysfs attributes
 active_bo and free_bo

Hi, Thanks for your review and most importantly your patience :)

On Tue, Jun 24, 2025 at 9:09 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> You really need to slow down with the new versions.
>
> On Tue, Jun 24, 2025 at 8:07 PM Abdelrahman Fekry
> <abdelrahmanfekry375@...il.com> wrote:
> >
> > The sysfs attributes active_bo and free_bo expose internal buffer state used
> > only for debugging purposes. These are not part of any standard kernel ABI,
> > and needs to be removed before this driver can be moved out of drivers/staging.
>
> needs --> need
> can --> may
>
noted , will fix this
> > - Remove active_bo and free_bo attributes
> > - Remove group registeration calls form hmm_init() and hmm_cleanup()
>
> registration
>
noted , will fix this
> > Suggested-by : Hans de Goede <hansg@...nel.org>
>
> This is not a tag. Check Submitting Patches documentation and find the
> issue and fix it accordingly.
>
noted , i now know the issue and will fix it
> --
> With Best Regards,
> Andy Shevchenko

Best Regards,
Abdelrahman Fekry