linux-kernel - Re: [PATCH v2 net-next 0/3] change some statistics to 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250625133224.275a8635@kernel.org>
Date: Wed, 25 Jun 2025 13:32:24 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: Wei Fang <wei.fang@....com>, Claudiu Manoil <claudiu.manoil@....com>,
 Vladimir Oltean <vladimir.oltean@....com>, Clark Wang
 <xiaoning.wang@....com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: Re: [PATCH v2 net-next 0/3] change some statistics to 64-bit

On Wed, 25 Jun 2025 17:34:59 +0100 Simon Horman wrote:
> > Simon has posted a patch [1] to fix the sparse warnings. Do I need to wait until
> > Simon's patch is applied to the net-next tree and then resend this patch set?
> > 
> > [1] https://lore.kernel.org/imx/20250624-etnetc-le-v1-1-a73a95d96e4e@kernel.org/  
> 
> Yes, I have confirmed that with patch[1] applied this patch-set
> does not introduce any Sparse warnings (in my environment).
> 
> I noticed the Sparse warnings that are otherwise introduced when reviewing
> v1 of this patchset which is why I crated patch[1].
> 
> The issue is that there is are long standing Sparse warnings - which
> highlight a driver bug, albeit one that doesn't manifest with in tree
> users. They is due to an unnecessary call to le64_to_cpu(). The warnings
> are:
> 
>   .../enetc_hw.h:513:16: warning: cast to restricted __le64
>   .../enetc_hw.h:513:16: warning: restricted __le64 degrades to integer
>   .../enetc_hw.h:513:16: warning: cast to restricted __le64
> 
> Patches 2/3 and 3/3 multiply the incidence of the above 3 warnings because
> they increase the callers of the inline function where the problem lies.
> 
> But I'd argue that, other than noise, they don't make things worse.
> The bug doesn't manifest for in-tree users (and if it did, it would
> have been manifesting anyway).
> 
> So I'd advocate accepting this series (or not) independent of resolving
> the Sparse warnings. Which should disappear when patch[1], or some variant
> thereof, is accepted (via net or directly into net-next).

All fair points, but unfortunately if there is a build issue 
the patches are not fed into the full CI cycle. Simon's fix
will hit net-next tomorrow, let's get these reposted tomorrow
so we can avoid any (unlikely) surprises?