linux-kernel - Re: [PATCH 3/5] nvme-pci: use block layer helpers to calculate num of queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ceb8e40d-04a3-42ae-bdc1-1033cf239073@nvidia.com>
Date: Wed, 25 Jun 2025 04:37:33 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Daniel Wagner <wagi@...nel.org>, Jens Axboe <axboe@...nel.dk>, Christoph
 Hellwig <hch@....de>
CC: Keith Busch <kbusch@...nel.org>, Sagi Grimberg <sagi@...mberg.me>,
	"Michael S. Tsirkin" <mst@...hat.com>, "Martin K. Petersen"
	<martin.petersen@...cle.com>, Thomas Gleixner <tglx@...utronix.de>, Costa
 Shulyupin <costa.shul@...hat.com>, Juri Lelli <juri.lelli@...hat.com>,
	Valentin Schneider <vschneid@...hat.com>, Waiman Long <llong@...hat.com>,
	Ming Lei <ming.lei@...hat.com>, Frederic Weisbecker <frederic@...nel.org>,
	Hannes Reinecke <hare@...e.de>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-block@...r.kernel.org"
	<linux-block@...r.kernel.org>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>, "megaraidlinux.pdl@...adcom.com"
	<megaraidlinux.pdl@...adcom.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "storagedev@...rochip.com"
	<storagedev@...rochip.com>, "virtualization@...ts.linux.dev"
	<virtualization@...ts.linux.dev>, "GR-QLogic-Storage-Upstream@...vell.com"
	<GR-QLogic-Storage-Upstream@...vell.com>
Subject: Re: [PATCH 3/5] nvme-pci: use block layer helpers to calculate num of
 queues

On 6/17/25 06:43, Daniel Wagner wrote:
> The calculation of the upper limit for queues does not depend solely on
> the number of possible CPUs; for example, the isolcpus kernel
> command-line option must also be considered.
>
> To account for this, the block layer provides a helper function to
> retrieve the maximum number of queues. Use it to set an appropriate
> upper queue number limit.
>
> Reviewed-by: Christoph Hellwig<hch@....de>
> Reviewed-by: Hannes Reinecke<hare@...e.de>
> Signed-off-by: Daniel Wagner<wagi@...nel.o

Thanks a lot for this it really makes code clean with a new helper
which shows association with queue than open coded cpu helper.

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck