linux-kernel - [PATCH v3 0/4] Fix soc-button-array debounce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250625215813.3477840-1-superm1@kernel.org>
Date: Wed, 25 Jun 2025 16:58:09 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Hans de Goede <hansg@...nel.org>,
	Mika Westerberg <westeri@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-gpio@...r.kernel.org (open list:GPIO ACPI SUPPORT),
	linux-acpi@...r.kernel.org (open list:GPIO ACPI SUPPORT),
	linux-kernel@...r.kernel.org (open list),
	linux-input@...r.kernel.org (open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...),
	Mario Limonciello <mario.limonciello@....com>
Subject: [PATCH v3 0/4] Fix soc-button-array debounce

From: Mario Limonciello <mario.limonciello@....com>

I have some hardware in front of me that uses the soc-button-array
driver but the power button doesn't work.

Digging into it, it's because the ASL prescribes a debounce of 0 for
the power button, but the soc-button-array driver hardcodes 50ms.

Hardcoding it to what the ASL expects the power button works.

I looked at the callpath into the GPIO core and I believe it's
because the debounce value from _CRS is never programmed to the
hardware the way that the GPIO gets setup.

This series add that programming path and then sets the hardcoded
value on on some quirked systems.  Hopefully Hans can confirm this
continues to work on the hardware that he originally developed the
hardcoding for.

---
v3:
 * Use Hans suggestion to force software debounce instead of a quirk
 * Fix a resume issue identified from testing this series

Mario Limonciello (4):
  gpiolib: acpi: Add a helper for programming debounce
  gpiolib: acpi: Program debounce when finding GPIO
  Input: Don't program hw debounce for soc_button_array devices
  Input: Don't send fake button presses to wake system

 drivers/gpio/gpiolib-acpi-core.c      | 25 ++++++++++++++-----------
 drivers/input/keyboard/gpio_keys.c    | 14 ++++++--------
 drivers/input/misc/soc_button_array.c |  1 +
 include/linux/gpio_keys.h             |  2 ++
 4 files changed, 23 insertions(+), 19 deletions(-)

-- 
2.43.0