[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250625215813.3477840-5-superm1@kernel.org>
Date: Wed, 25 Jun 2025 16:58:13 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Hans de Goede <hansg@...nel.org>,
Mika Westerberg <westeri@...nel.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-gpio@...r.kernel.org (open list:GPIO ACPI SUPPORT),
linux-acpi@...r.kernel.org (open list:GPIO ACPI SUPPORT),
linux-kernel@...r.kernel.org (open list),
linux-input@...r.kernel.org (open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...),
Mario Limonciello <mario.limonciello@....com>
Subject: [PATCH v3 4/4] Input: Don't send fake button presses to wake system
From: Mario Limonciello <mario.limonciello@....com>
Sending an input event to wake a system does wake it, but userspace picks
up the keypress and processes it. This isn't the intended behavior as it
causes a suspended system to wake up and then potentially turn off if
userspace is configured to turn off on power button presses.
Instead send a PM wakeup event for the PM core to handle waking the system.
Cc: Hans de Goede <hansg@...nel.org>
Fixes: 0f107573da417 ("Input: gpio_keys - handle the missing key press event in resume phase")
Signed-off-by: Mario Limonciello <mario.limonciello@....com>
---
drivers/input/keyboard/gpio_keys.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 773aa5294d269..4c6876b099c43 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -420,12 +420,7 @@ static irqreturn_t gpio_keys_gpio_isr(int irq, void *dev_id)
pm_stay_awake(bdata->input->dev.parent);
if (bdata->suspended &&
(button->type == 0 || button->type == EV_KEY)) {
- /*
- * Simulate wakeup key press in case the key has
- * already released by the time we got interrupt
- * handler to run.
- */
- input_report_key(bdata->input, button->code, 1);
+ pm_wakeup_event(bdata->input->dev.parent, 0);
}
}
--
2.43.0
Powered by blists - more mailing lists