| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250625231838.1897085-16-pasha.tatashin@soleen.com>
Date: Wed, 25 Jun 2025 23:18:02 +0000
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: pratyush@...nel.org,
jasonmiu@...gle.com,
graf@...zon.com,
changyuanl@...gle.com,
pasha.tatashin@...een.com,
rppt@...nel.org,
dmatlack@...gle.com,
rientjes@...gle.com,
corbet@....net,
rdunlap@...radead.org,
ilpo.jarvinen@...ux.intel.com,
kanie@...ux.alibaba.com,
ojeda@...nel.org,
aliceryhl@...gle.com,
masahiroy@...nel.org,
akpm@...ux-foundation.org,
tj@...nel.org,
yoann.congal@...le.fr,
mmaurer@...gle.com,
roman.gushchin@...ux.dev,
chenridong@...wei.com,
axboe@...nel.dk,
mark.rutland@....com,
jannh@...gle.com,
vincent.guittot@...aro.org,
hannes@...xchg.org,
dan.j.williams@...el.com,
david@...hat.com,
joel.granados@...nel.org,
rostedt@...dmis.org,
anna.schumaker@...cle.com,
song@...nel.org,
zhangguopeng@...inos.cn,
linux@...ssschuh.net,
linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org,
linux-mm@...ck.org,
gregkh@...uxfoundation.org,
tglx@...utronix.de,
mingo@...hat.com,
bp@...en8.de,
dave.hansen@...ux.intel.com,
x86@...nel.org,
hpa@...or.com,
rafael@...nel.org,
dakr@...nel.org,
bartosz.golaszewski@...aro.org,
cw00.choi@...sung.com,
myungjoo.ham@...sung.com,
yesanishhere@...il.com,
Jonathan.Cameron@...wei.com,
quic_zijuhu@...cinc.com,
aleksander.lobakin@...el.com,
ira.weiny@...el.com,
andriy.shevchenko@...ux.intel.com,
leon@...nel.org,
lukas@...ner.de,
bhelgaas@...gle.com,
wagi@...nel.org,
djeffery@...hat.com,
stuart.w.hayes@...il.com,
ptyadav@...zon.de,
lennart@...ttering.net,
brauner@...nel.org,
linux-api@...r.kernel.org,
linux-fsdevel@...r.kernel.org
Subject: [PATCH v1 15/32] liveupdate: luo_files: implement file systems callbacks
Implements the core logic within luo_files.c to invoke the prepare,
reboot, finish, and cancel callbacks for preserved file instances,
replacing the previous stub implementations. It also handles
the persistence and retrieval of the u64 data payload associated with
each file via the LUO FDT.
This completes the core mechanism enabling registered files handlers to actively
manage file state across the live update transition using the LUO framework.
Signed-off-by: Pasha Tatashin <pasha.tatashin@...een.com>
---
kernel/liveupdate/luo_files.c | 166 +++++++++++++++++++++++++++++++++-
1 file changed, 164 insertions(+), 2 deletions(-)
diff --git a/kernel/liveupdate/luo_files.c b/kernel/liveupdate/luo_files.c
index 3582f1ec96c4..cd956ea69f43 100644
--- a/kernel/liveupdate/luo_files.c
+++ b/kernel/liveupdate/luo_files.c
@@ -325,31 +325,193 @@ static int luo_files_fdt_setup(void)
return ret;
}
+static int luo_files_prepare_one(struct luo_file *h)
+{
+ int ret = 0;
+
+ mutex_lock(&h->mutex);
+ if (h->state == LIVEUPDATE_STATE_NORMAL) {
+ if (h->fh->ops->prepare) {
+ ret = h->fh->ops->prepare(h->file, h->fh->arg,
+ &h->private_data);
+ }
+ if (!ret)
+ h->state = LIVEUPDATE_STATE_PREPARED;
+ } else {
+ WARN_ON_ONCE(h->state != LIVEUPDATE_STATE_PREPARED &&
+ h->state != LIVEUPDATE_STATE_FROZEN);
+ }
+ mutex_unlock(&h->mutex);
+
+ return ret;
+}
+
+static int luo_files_freeze_one(struct luo_file *h)
+{
+ int ret = 0;
+
+ mutex_lock(&h->mutex);
+ if (h->state == LIVEUPDATE_STATE_PREPARED) {
+ if (h->fh->ops->freeze) {
+ ret = h->fh->ops->freeze(h->file, h->fh->arg,
+ &h->private_data);
+ }
+ if (!ret)
+ h->state = LIVEUPDATE_STATE_FROZEN;
+ } else {
+ WARN_ON_ONCE(h->state != LIVEUPDATE_STATE_FROZEN);
+ }
+ mutex_unlock(&h->mutex);
+
+ return ret;
+}
+
+static void luo_files_finish_one(struct luo_file *h)
+{
+ mutex_lock(&h->mutex);
+ if (h->state == LIVEUPDATE_STATE_UPDATED) {
+ if (h->fh->ops->finish) {
+ h->fh->ops->finish(h->file, h->fh->arg, h->private_data,
+ h->reclaimed);
+ }
+ h->state = LIVEUPDATE_STATE_NORMAL;
+ } else {
+ WARN_ON_ONCE(h->state != LIVEUPDATE_STATE_NORMAL);
+ }
+ mutex_unlock(&h->mutex);
+}
+
+static void luo_files_cancel_one(struct luo_file *h)
+{
+ int ret;
+
+ mutex_lock(&h->mutex);
+ if (h->state == LIVEUPDATE_STATE_NORMAL)
+ goto exit_unlock;
+
+ ret = WARN_ON_ONCE(h->state != LIVEUPDATE_STATE_PREPARED &&
+ h->state != LIVEUPDATE_STATE_FROZEN);
+ if (ret)
+ goto exit_unlock;
+
+ if (h->fh->ops->cancel)
+ h->fh->ops->cancel(h->file, h->fh->arg, h->private_data);
+ h->private_data = 0;
+ h->state = LIVEUPDATE_STATE_NORMAL;
+
+exit_unlock:
+ mutex_unlock(&h->mutex);
+}
+
+static void __luo_files_cancel(struct luo_file *boundary_file)
+{
+ unsigned long token;
+ struct luo_file *h;
+
+ xa_for_each(&luo_files_xa_out, token, h) {
+ if (h == boundary_file)
+ break;
+
+ luo_files_cancel_one(h);
+ }
+ luo_files_fdt_cleanup();
+}
+
+static int luo_files_commit_data_to_fdt(void)
+{
+ int node_offset, ret;
+ unsigned long token;
+ char token_str[19];
+ struct luo_file *h;
+
+ xa_for_each(&luo_files_xa_out, token, h) {
+ snprintf(token_str, sizeof(token_str), "%#0llx", (u64)token);
+ node_offset = fdt_subnode_offset(luo_file_fdt_out,
+ 0,
+ token_str);
+ ret = fdt_setprop(luo_file_fdt_out, node_offset, "data",
+ &h->private_data, sizeof(h->private_data));
+ if (ret < 0) {
+ pr_err("Failed to set data property for token %s: %s\n",
+ token_str, fdt_strerror(ret));
+ return -ENOSPC;
+ }
+ }
+
+ return 0;
+}
+
static int luo_files_prepare(void *arg, u64 *data)
{
+ unsigned long token;
+ struct luo_file *h;
int ret;
ret = luo_files_fdt_setup();
if (ret)
return ret;
- *data = __pa(luo_file_fdt_out);
+ xa_for_each(&luo_files_xa_out, token, h) {
+ ret = luo_files_prepare_one(h);
+ if (ret < 0) {
+ pr_err("Prepare failed for file token %#0llx handler '%s' [%d]\n",
+ (u64)token, h->fh->compatible, ret);
+ __luo_files_cancel(h);
+
+ return ret;
+ }
+ }
+
+ ret = luo_files_commit_data_to_fdt();
+ if (ret)
+ __luo_files_cancel(NULL);
+ else
+ *data = __pa(luo_file_fdt_out);
return ret;
}
static int luo_files_freeze(void *arg, u64 *data)
{
- return 0;
+ unsigned long token;
+ struct luo_file *h;
+ int ret;
+
+ xa_for_each(&luo_files_xa_out, token, h) {
+ ret = luo_files_freeze_one(h);
+ if (ret < 0) {
+ pr_err("Freeze callback failed for file token %#0llx handler '%s' [%d]\n",
+ (u64)token, h->fh->compatible, ret);
+ __luo_files_cancel(h);
+
+ return ret;
+ }
+ }
+
+ ret = luo_files_commit_data_to_fdt();
+ if (ret)
+ __luo_files_cancel(NULL);
+
+ return ret;
}
static void luo_files_finish(void *arg, u64 data)
{
+ unsigned long token;
+ struct luo_file *h;
+
luo_files_recreate_luo_files_xa_in();
+ xa_for_each(&luo_files_xa_in, token, h) {
+ luo_files_finish_one(h);
+ mutex_destroy(&h->mutex);
+ kfree(h);
+ }
+ xa_destroy(&luo_files_xa_in);
}
static void luo_files_cancel(void *arg, u64 data)
{
+ __luo_files_cancel(NULL);
}
static const struct liveupdate_subsystem_ops luo_file_subsys_ops = {
--
2.50.0.727.gbf7dc18ff4-goog
Powered by blists - more mailing lists