linux-kernel - Re: [PATCH v1 03/32] kho: warn if KHO is disabled due to an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac8efa08-3f85-4532-8762-573ebd258ca7@infradead.org>
Date: Wed, 25 Jun 2025 16:56:48 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Pasha Tatashin <pasha.tatashin@...een.com>, pratyush@...nel.org,
 jasonmiu@...gle.com, graf@...zon.com, changyuanl@...gle.com,
 rppt@...nel.org, dmatlack@...gle.com, rientjes@...gle.com, corbet@....net,
 ilpo.jarvinen@...ux.intel.com, kanie@...ux.alibaba.com, ojeda@...nel.org,
 aliceryhl@...gle.com, masahiroy@...nel.org, akpm@...ux-foundation.org,
 tj@...nel.org, yoann.congal@...le.fr, mmaurer@...gle.com,
 roman.gushchin@...ux.dev, chenridong@...wei.com, axboe@...nel.dk,
 mark.rutland@....com, jannh@...gle.com, vincent.guittot@...aro.org,
 hannes@...xchg.org, dan.j.williams@...el.com, david@...hat.com,
 joel.granados@...nel.org, rostedt@...dmis.org, anna.schumaker@...cle.com,
 song@...nel.org, zhangguopeng@...inos.cn, linux@...ssschuh.net,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, linux-mm@...ck.org,
 gregkh@...uxfoundation.org, tglx@...utronix.de, mingo@...hat.com,
 bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
 rafael@...nel.org, dakr@...nel.org, bartosz.golaszewski@...aro.org,
 cw00.choi@...sung.com, myungjoo.ham@...sung.com, yesanishhere@...il.com,
 Jonathan.Cameron@...wei.com, quic_zijuhu@...cinc.com,
 aleksander.lobakin@...el.com, ira.weiny@...el.com,
 andriy.shevchenko@...ux.intel.com, leon@...nel.org, lukas@...ner.de,
 bhelgaas@...gle.com, wagi@...nel.org, djeffery@...hat.com,
 stuart.w.hayes@...il.com, ptyadav@...zon.de, lennart@...ttering.net,
 brauner@...nel.org, linux-api@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v1 03/32] kho: warn if KHO is disabled due to an error



On 6/25/25 4:17 PM, Pasha Tatashin wrote:
> During boot scratch area is allocated based on command line
> parameters or auto calculated. However, scratch area may fail
> to allocate, and in that case KHO is disabled. Currently,
> no warning is printed that KHO is disabled, which makes it
> confusing for the end user to figure out why KHO is not
> available. Add the missing warning message.

Are users even going to know what "KHO" means in the warning message?

> 
> Signed-off-by: Pasha Tatashin <pasha.tatashin@...een.com>
> ---
>  kernel/kexec_handover.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c
> index 1ff6b242f98c..069d5890841c 100644
> --- a/kernel/kexec_handover.c
> +++ b/kernel/kexec_handover.c
> @@ -565,6 +565,7 @@ static void __init kho_reserve_scratch(void)
>  err_free_scratch_desc:
>  	memblock_free(kho_scratch, kho_scratch_cnt * sizeof(*kho_scratch));
>  err_disable_kho:
> +	pr_warn("Failed to reserve scratch area, disabling KHO\n");
>  	kho_enable = false;
>  }
>  

-- 
~Randy