linux-kernel - Re: [PATCH v6 2/9] dt-bindings: soc: imx-blk-ctrl: add i.MX91 blk-ctrl compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22d911a2-3bf1-45ee-9037-c6d8cbd686fa@kernel.org>
Date: Wed, 25 Jun 2025 08:10:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Joy Zou <joy.zou@....com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
 catalin.marinas@....com, will@...nel.org, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
 ulf.hansson@...aro.org, richardcochran@...il.com, kernel@...gutronix.de,
 festevam@...il.com, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com, linux-pm@...r.kernel.or,
 ye.li@....com, ping.bai@....com, aisheng.dong@....com
Subject: Re: [PATCH v6 2/9] dt-bindings: soc: imx-blk-ctrl: add i.MX91
 blk-ctrl compatible

On 24/06/2025 21:08, Frank Li wrote:
>>>>> +        clock-names:
>>>>> +          items:
>>>>> +            - const: apb
>>>>> +            - const: axi
>>>>> +            - const: nic
>>>>> +            - const: disp
>>>>> +            - const: cam
>>>>> +            - const: lcdif
>>>>> +            - const: isi
>>>>> +            - const: csi
>>>>
>>>> No, look at other bindings how they share clock lists.
>>>
>>> Sorry, this method is what I suggested. becuase there are pxp between cam
>>> and lcdif, can't use simple minItems/maxItems to limit list.
>>
>> The point is to put new items, so pxp, at the end.
> 
> There are already a list for imx93. If change list order, it will break
> ABI. This was rejected at other binding doc review.
I see, I mixed the SoCs. It is a pity you upstream that way and do not
try to make the list common. Anyway names indeed need to be constrained
per variant, but the rest of the comments stay.

Best regards,
Krzysztof