linux-kernel - Re: [PATCH v2] ALSA: usb-audio: qcom: fix NULL pointer dereference in qmi_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ldpgjpw2.wl-tiwai@suse.de>
Date: Wed, 25 Jun 2025 08:29:01 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Pei Xiao <xiaopei01@...inos.cn>
Cc: tiwai@...e.com,
	perex@...ex.cz,
	quic_wcheng@...cinc.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: usb-audio: qcom: fix NULL pointer dereference in qmi_stop_session

On Tue, 24 Jun 2025 11:00:47 +0200,
Pei Xiao wrote:
> 
> The find_substream() call may return NULL, but the error path
> dereferenced 'subs' unconditionally via dev_err(&subs->dev->dev, ...),
> causing a NULL pointer dereference when subs is NULL.
> 
> Fix by switching to &uadev[idx].udev->dev which is always valid
> in this context.
> 
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>

Applied now.  Thanks.


Takashi