linux-kernel - [PATCH v2] wifi: rsi: Use usb_endpoint_xfer_bulk() rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9de5fb9e-bbe9-4f27-9370-1fff9e3c9fe2@web.de>
Date: Wed, 25 Jun 2025 08:55:17 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-wireless@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Chen Ni <nichen@...as.ac.cn>, Kalle Valo <kvalo@...nel.org>
Subject: [PATCH v2] wifi: rsi: Use usb_endpoint_xfer_bulk() rather than
 duplicating its implementation

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 25 Jun 2025 08:46:02 +0200

Reuse existing functionality from usb_endpoint_xfer_bulk() instead of
keeping duplicate source code.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---

V2:
Another change possibility was taken better into account for the USB API.


 drivers/net/wireless/rsi/rsi_91x_usb.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c
index dccc139cabb2..31707b543c19 100644
--- a/drivers/net/wireless/rsi/rsi_91x_usb.c
+++ b/drivers/net/wireless/rsi/rsi_91x_usb.c
@@ -122,8 +122,7 @@ static int rsi_find_bulk_in_and_out_endpoints(struct usb_interface *interface,
 
 		if (!dev->bulkin_endpoint_addr[bin_found] &&
 		    (endpoint->bEndpointAddress & USB_DIR_IN) &&
-		    ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) ==
-		    USB_ENDPOINT_XFER_BULK)) {
+		    usb_endpoint_xfer_bulk(endpoint)) {
 			buffer_size = endpoint->wMaxPacketSize;
 			dev->bulkin_size[bin_found] = buffer_size;
 			dev->bulkin_endpoint_addr[bin_found] =
@@ -133,8 +132,7 @@ static int rsi_find_bulk_in_and_out_endpoints(struct usb_interface *interface,
 
 		if (!dev->bulkout_endpoint_addr[bout_found] &&
 		    !(endpoint->bEndpointAddress & USB_DIR_IN) &&
-		    ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) ==
-		    USB_ENDPOINT_XFER_BULK)) {
+		    usb_endpoint_xfer_bulk(endpoint)) {
 			buffer_size = endpoint->wMaxPacketSize;
 			dev->bulkout_endpoint_addr[bout_found] =
 				endpoint->bEndpointAddress;
-- 
2.50.0