linux-kernel - Re: [PATCH v5 3/4] drm/bridge: microchip-lvds: add atomic pre_enable() and post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250625-mongrel-of-holistic-fascination-4f1a44@houat>
Date: Wed, 25 Jun 2025 08:57:24 +0200
From: Maxime Ripard <mripard@...nel.org>
To: Dharma Balasubiramani <dharma.b@...rochip.com>
Cc: Manikandan Muralidharan <manikandan.m@...rochip.com>, 
	Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Robert Foss <rfoss@...nel.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>, 
	Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/4] drm/bridge: microchip-lvds: add atomic
 pre_enable() and post_disable()

On Wed, Jun 25, 2025 at 10:26:11AM +0530, Dharma Balasubiramani wrote:
> pm_runtime_get_sync() and clk_prepare_enable() must be outside the atomic
> context, hence move the sleepable operations accordingly.
> 
> - atomic_pre_enable() handles pm_runtime and clock preparation
> - atomic_enable() enables the serializer based on panel format
> - atomic_disable() turns off the serializer
> - atomic_post_disable() disables clock and releases runtime PM
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b@...rochip.com>

If that's the reason you wanted to split the enable and disable hooks in
two, you don't need to. You can sleep in any context here.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (274 bytes)