linux-kernel - Re: [PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFukNGMgZyKGlCvN@shikoro>
Date: Wed, 25 Jun 2025 09:24:37 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Jorge Marques <jorge.marques@...log.com>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Frank Li <Frank.Li@....com>,
	Przemysław Gaj <pgaj@...ence.com>,
	linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and
 i3c_writel_fifo()

On Tue, Jun 24, 2025 at 11:06:04AM +0200, Jorge Marques wrote:
> The I3C abstraction expects u8 buffers, but some controllers operate with
> a 32-bit bus width FIFO and cannot flag valid bytes individually. To avoid
> reading or writing outside the buffer bounds, use 32-bit accesses where
> possible and apply memcpy for any remaining bytes
> 
> Signed-off-by: Jorge Marques <jorge.marques@...log.com>

As per [1]:
Suggested-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

My concern is rejected, and the rest looks good to me, so:
Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

It still works nicely with the Renesas driver:
Tested-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

[1] https://lore.kernel.org/r/20250611093934.4208-5-wsa+renesas@sang-engineering.com