linux-kernel - Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFuq2JFZZhC1r3N4@hovoldconsulting.com>
Date: Wed, 25 Jun 2025 09:52:56 +0200
From: Johan Hovold <johan@...nel.org>
To: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
Cc: Bjorn Andersson <andersson@...nel.org>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, laurentiu.tudor1@...l.com,
	abel.vesa@...aro.org, bryan.odonoghue@...aro.org,
	jens.glathe@...schoolsolutions.biz
Subject: Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010
 by default

On Wed, Jun 25, 2025 at 12:41:20AM +0200, Aleksandrs Vinarskis wrote:
> pm8010 is a camera specific PMIC, and may not be present on some
> devices. These may instead use a dedicated vreg for this purpose (Dell
> XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
> alltogether (Lenovo Thinbook 16, Lenovo Yoga..).
> 
> Disable pm8010 by default, let platforms that actually have one onboard
> enable it instead.
> 
> This fixes dmesg errors of PMIC failing to probe, and on Dell XPS 9345
> fixes the issue of power button not working as power off/suspend (only
> long press cuts the power).
> 
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> 

Nit: There shouldn't be a new line here after the Fixes tag.

Not sure how this breaks the power button on the XPS, but sounds like
this one should be marked for stable backport:

Cc: stable@...r.kernel.org

> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@...il.com>

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>

Johan