linux-kernel - RE: [PATCH 03/10] mei: vsc: Don't call vsc_tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB63667FFDD378306D42A852BBED7BA@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Wed, 25 Jun 2025 07:59:52 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: Hans de Goede <hansg@...nel.org>, Sakari Ailus
	<sakari.ailus@...ux.intel.com>, Stanislaw Gruszka
	<stanislaw.gruszka@...ux.intel.com>
CC: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 03/10] mei: vsc: Don't call vsc_tp_reset() a second time
 on shutdown

> Subject: [PATCH 03/10] mei: vsc: Don't call vsc_tp_reset() a second time on
> shutdown
> 
> Now that mei_vsc_hw_reset() no longer re-inits the VSC when called from
> mei_stop(), vsc_tp_shutdown() unregistering the platform-device, which
> runs mei_stop() is sufficient to put the VSC in a clean state.
> 

Reviewed-by: Alexander Usyskin <alexander.usyskin@...el.com>

> Signed-off-by: Hans de Goede <hansg@...nel.org>
> ---
>  drivers/misc/mei/vsc-tp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
> index 99a55451e1fc..4a262e2117e4 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -547,8 +547,6 @@ static void vsc_tp_shutdown(struct spi_device *spi)
> 
>  	mutex_destroy(&tp->mutex);
> 
> -	vsc_tp_reset(tp);
> -
>  	free_irq(spi->irq, tp);
>  }
> 
> --
> 2.49.0