linux-kernel - Re: [RFC PATCH v7 18/37] x86/apic: Simplify bitwise operations on apic bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6dfdfc71-435d-42c3-a46d-84aca776a47e@amd.com>
Date: Wed, 25 Jun 2025 06:48:04 +0530
From: Neeraj Upadhyay <Neeraj.Upadhyay@....com>
To: "Huang, Kai" <kai.huang@...el.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
 "tiala@...rosoft.com" <tiala@...rosoft.com>,
 "Vasant.Hegde@....com" <Vasant.Hegde@....com>,
 "Suravee.Suthikulpanit@....com" <Suravee.Suthikulpanit@....com>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
 "Thomas.Lendacky@....com" <Thomas.Lendacky@....com>,
 "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
 "seanjc@...gle.com" <seanjc@...gle.com>, "mingo@...hat.com"
 <mingo@...hat.com>, "pbonzini@...hat.com" <pbonzini@...hat.com>,
 "tglx@...utronix.de" <tglx@...utronix.de>,
 "huibo.wang@....com" <huibo.wang@....com>,
 "Santosh.Shukla@....com" <Santosh.Shukla@....com>,
 "nikunj@....com" <nikunj@....com>, "hpa@...or.com" <hpa@...or.com>,
 "peterz@...radead.org" <peterz@...radead.org>, "bp@...en8.de"
 <bp@...en8.de>, "francescolavra.fl@...il.com" <francescolavra.fl@...il.com>,
 "naveen.rao@....com" <naveen.rao@....com>,
 "David.Kaplan@....com" <David.Kaplan@....com>,
 "x86@...nel.org" <x86@...nel.org>
Subject: Re: [RFC PATCH v7 18/37] x86/apic: Simplify bitwise operations on
 apic bitmap



On 6/24/2025 4:07 PM, Huang, Kai wrote:
> On Tue, 2025-06-10 at 23:24 +0530, Neeraj Upadhyay wrote:
>> Use 'regs' as a contiguous linear bitmap in  apic_{set|
> 					      ^
> 					      double whitespace here
> 

Will fix.

>> clear|test}_vector() while doing bitwise operations.
>> This makes the code simpler by eliminating the need to
>> determine the offset of the 32-bit register and the vector
>> bit location within that register prior to performing
>> bitwise operations.
>>
>> This change results in slight increase in generated code
>> size for gcc-14.2.
> 
> Seems the text wrap here is different from other patches, i.e., the
> 'textwidth' seems much smaller.
> 

Will fix it.

>>
>> - Without change
>>
>> apic_set_vector:
> 
> Perhaps add a blank line here to make it easier to read (also consistent
> with below).
> 

Ack


Thanks for the review!


- Neeraj