linux-kernel - [PATCH v3] fs/buffer: remove the min and max limit checks in __getblk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250625083704.167993-1-p.raghav@samsung.com>
Date: Wed, 25 Jun 2025 10:37:04 +0200
From: Pankaj Raghav <p.raghav@...sung.com>
To: Alexander Viro <viro@...iv.linux.org.uk>,
	Jan Kara <jack@...e.cz>,
	mcgrof@...nel.org,
	Christian Brauner <brauner@...nel.org>
Cc: kernel@...kajraghav.com,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	gost.dev@...sung.com,
	Pankaj Raghav <p.raghav@...sung.com>,
	Matthew Wilcox <willy@...radead.org>
Subject: [PATCH v3] fs/buffer: remove the min and max limit checks in __getblk_slow()

All filesystems will already check the max and min value of their block
size during their initialization. __getblk_slow() is a very low-level
function to have these checks. Remove them and only check for logical
block size alignment.

Suggested-by: Matthew Wilcox <willy@...radead.org>
Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
---
Changes since v2:
- Removed the max and min checks in __getblk_slow().

 fs/buffer.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index a14d281c6a74..a1aa01ebc0ce 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1122,13 +1122,9 @@ __getblk_slow(struct block_device *bdev, sector_t block,
 {
 	bool blocking = gfpflags_allow_blocking(gfp);
 
-	if (unlikely(size & (bdev_logical_block_size(bdev) - 1) ||
-		     (size < 512 || size > PAGE_SIZE))) {
-		printk(KERN_ERR "getblk(): invalid block size %d requested\n",
-					size);
-		printk(KERN_ERR "logical block size: %d\n",
-					bdev_logical_block_size(bdev));
-
+	if (unlikely(size & (bdev_logical_block_size(bdev) - 1))) {
+		printk(KERN_ERR "getblk(): block size %d not aligned to logical block size %d\n",
+		       size, bdev_logical_block_size(bdev));
 		dump_stack();
 		return NULL;
 	}

base-commit: 6ae58121126dcf8efcc2611f216a36a5e50b8ad9
-- 
2.49.0