linux-kernel - Re: [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro: Update bindings for clocks to support ADSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14e0e012-0283-4a17-8cb1-fe96785b11ac@kernel.org>
Date: Wed, 25 Jun 2025 10:44:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Prasad Kumpatla <quic_pkumpatl@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Srinivas Kandagatla <srini@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
 kernel@....qualcomm.com, Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Subject: Re: [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro:
 Update bindings for clocks to support ADSP

On 25/06/2025 10:29, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
> 
> Manage clock settings for ADSP solution.
> 
> On Existing ADSP bypass solutions, The macro and dcodec GDSCs are

s/The/the/

OK, this has to be expressed in schema - oneOf in top-level for presence
(required) power domains or clocks (contains for these names).


> enabled using power domains in lpass-va-macro which is not applicable
> for ADSP based platform.
> 
> Reference:
>  - qcom,lpass-tx-macro.yaml
>  - qcom,lpass-rx-macro.yaml

I don't understand this reference.

> 
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
> ---
>  .../bindings/sound/qcom,lpass-va-macro.yaml        | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> index f41deaa6f4df..38679a4f21fa 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> @@ -75,14 +75,20 @@ allOf:
>          compatible:
>            contains:
>              const: qcom,sc7280-lpass-va-macro
> +

Why? It's a different style now. Don't introduce random whitespace changes.


Best regards,
Krzysztof