linux-kernel - Re: [PATCH v3 3/5] arm64: dts: rockchip: add header for RK8XX PMIC constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nja7c4ikyoxpoque62c52eboa22gt4zt72vaseaoo5bbzyrlor@gte3jm2sbecv>
Date: Wed, 25 Jun 2025 03:26:37 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Quentin Schulz <quentin.schulz@...rry.de>
Cc: Quentin Schulz <foss+kernel@...il.net>, Lee Jones <lee@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>, 
	Lukasz Czechowski <lukasz.czechowski@...umatec.com>, Daniel Semkowicz <dse@...umatec.com>, 
	Nicolas Frattaroli <nicolas.frattaroli@...labora.com>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/5] arm64: dts: rockchip: add header for RK8XX PMIC
 constants

Hi,

On Mon, Jun 23, 2025 at 11:48:27AM +0200, Quentin Schulz wrote:
> On 6/19/25 5:51 PM, Sebastian Reichel wrote:
> > On Wed, Jun 18, 2025 at 12:32:42PM +0200, Quentin Schulz wrote:
> > > From: Quentin Schulz <quentin.schulz@...rry.de>
> > > 
> > > To make it easier to read the device tree, let's add constants for the
> > > rockchip,reset-mode property values that are currently only applicable
> > > to RK806 PMIC.
> > > 
> > > Signed-off-by: Quentin Schulz <quentin.schulz@...rry.de>
> > > ---
> > >   arch/arm64/boot/dts/rockchip/rk8xx.h | 18 ++++++++++++++++++
> > 
> > I think this header should be in include/dt-bindings/, otherwise the
> 
> v2 did that and the feedback from dt-binding people was they didn't want (as
> far as I understood) unused constants as ABI[1][2].
> 
> [1]
> https://lore.kernel.org/all/704d75df-a484-4da3-9bcb-85b480e2ecf0@kernel.org/
> [2]
> https://lore.kernel.org/all/a9baf6b0-b668-4d10-b9de-b63eb3fd8f23@kernel.org/

I wonder if it would be considered an ABI, if the drivers would use
the values like this:

switch (value_from_dt) {
case RK806_RESTART:
case RK806_RESET:
case RK806_RESET_NOTIFY:
    program_register(...);
    break;
default:
    return dev_err_probe(dev, -EINVAL, "invalid restart setting");
}

IMHO register values not being an ABI is kind of weird, as this is a
very strong ABI from my POV - it's just not defined by us. But I don't
intent to fight for this, so ignore my comment :)

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)