linux-kernel - Re: [PATCH] wifi: ath11k: fix suspend use-after-free after probe failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFvBYaTf2SVooUrx@hovoldconsulting.com>
Date: Wed, 25 Jun 2025 11:29:05 +0200
From: Johan Hovold <johan@...nel.org>
To: Jeff Johnson <jeff.johnson@....qualcomm.com>
Cc: Johan Hovold <johan+linaro@...nel.org>,
	Jeff Johnson <jjohnson@...nel.org>, linux-wireless@...r.kernel.org,
	ath11k@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
	Baochen Qiang <quic_bqiang@...cinc.com>
Subject: Re: [PATCH] wifi: ath11k: fix suspend use-after-free after probe
 failure

On Tue, Jun 24, 2025 at 09:15:51AM -0700, Jeff Johnson wrote:
> On 6/24/2025 8:11 AM, Jeff Johnson wrote:
> > On 6/24/2025 1:32 AM, Johan Hovold wrote:
> >> On Tue, Jun 24, 2025 at 10:20:22AM +0200, Johan Hovold wrote:
> >>> Make sure to deregister the PM notifier to avoid a use-after-free on
> >>> suspend in case core initialisation fails (e.g. due to missing
> >>> firmware).
> >>
> >> Not sure it matters in this case, but forgot to include:
> >>
> >> Tested-on: WCN6855 hw2.0 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.41
> > 
> > I'll add that.
> > I'll also change the Link: to Closes: per checkpatch:
> > 
> > WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report

Checkpatch is just a tool and it's output should not be treated as
something that you must follow.

Linus reluctantly allowed Closes: to be used as an *alternative* to
Link: [1], but then there was mission creep and now checkpatch has
started warning about a perfectly valid Link: tag after Reported-by:
without that even being made clear in the commit message [2].

I'll stick with Link: (like Linus still do most of the time), but I
don't mind if you want to change this to Closes: for ath11k.

> Please check pending patch:
> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=2418079880408c5ae0b2a93f72af044eaff18cb6

Looks good, thanks.

Johan

[1] https://lore.kernel.org/lkml/CAHk-=wh0v1EeDV3v8TzK81nDC40=XuTdY2MCr0xy3m3FiBV3+Q@mail.gmail.com/
[2] https://lore.kernel.org/lkml/20230314-doc-checkpatch-closes-tag-v4-4-d26d1fa66f9f@tessares.net/