linux-kernel - Re: [PATCH net-next 6/7] net: splice: Drop nr_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250625100610.GO1562@horms.kernel.org>
Date: Wed, 25 Jun 2025 11:06:10 +0100
From: Simon Horman <horms@...nel.org>
To: Michal Luczaj <mhal@...x.co>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	David Ahern <dsahern@...nel.org>,
	Boris Pismenny <borisp@...dia.com>,
	John Fastabend <john.fastabend@...il.com>,
	Ayush Sawal <ayush.sawal@...lsio.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 6/7] net: splice: Drop nr_pages_max
 initialization

On Tue, Jun 24, 2025 at 11:53:53AM +0200, Michal Luczaj wrote:
> splice_pipe_desc::nr_pages_max was initialized unnecessary in commit
> 41c73a0d44c9 ("net: speedup skb_splice_bits()"). spd_fill_page() compares
> spd->nr_pages against a constant MAX_SKB_FRAGS, which makes setting
> nr_pages_max redundant.
> 
> Remove the assignment. No functional change intended.
> 
> Signed-off-by: Michal Luczaj <mhal@...x.co>

Reviewed-by: Simon Horman <horms@...nel.org>

> ---
> Probably the same thing in net/smc/smc_rx.c:smc_rx_splice()?

Yes, it seems so to me.