linux-kernel - RE: [PATCH 09/10] mei: vsc: Fix "BUG: Invalid wait context" lockdep error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB63661FD883CCA8A286CDAB3EED7BA@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Wed, 25 Jun 2025 10:12:50 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: Hans de Goede <hansg@...nel.org>, Sakari Ailus
	<sakari.ailus@...ux.intel.com>, Stanislaw Gruszka
	<stanislaw.gruszka@...ux.intel.com>
CC: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 09/10] mei: vsc: Fix "BUG: Invalid wait context" lockdep
 error

> Subject: [PATCH 09/10] mei: vsc: Fix "BUG: Invalid wait context" lockdep error
> 
> Kernels build with CONFIG_PROVE_RAW_LOCK_NESTING report the following
> tp-vsc lockdep error:
> 
> =============================
>  [ BUG: Invalid wait context ]
>  ...
>  swapper/10/0 is trying to lock:
>  ffff88819c271888 (&tp->xfer_wait){....}-{3:3},
>   at: __wake_up (kernel/sched/wait.c:106 kernel/sched/wait.c:127)
>  ...
>  Call Trace:
>  <IRQ>
>  ...
>  __raw_spin_lock_irqsave (./include/linux/spinlock_api_smp.h:111)
>  __wake_up (kernel/sched/wait.c:106 kernel/sched/wait.c:127)
>  vsc_tp_isr (drivers/misc/mei/vsc-tp.c:110) mei_vsc_hw
>  __handle_irq_event_percpu (kernel/irq/handle.c:158)
>  handle_irq_event (kernel/irq/handle.c:195 kernel/irq/handle.c:210)
>  handle_edge_irq (kernel/irq/chip.c:833)
>  ...
>  </IRQ>
> 
> The root-cause of this is the IRQF_NO_THREAD flag used by the intel-pinctrl
> code. Setting IRQF_NO_THREAD requires all interrupt handlers for GPIO ISRs
> to use raw-spinlocks only since normal spinlocks can sleep in PREEMPT-RT
> kernels and with IRQF_NO_THREAD the interrupt handlers will always run in
> an atomic context [1].
> 
> vsc_tp_isr() calls wake_up(&tp->xfer_wait), which uses a regular spinlock,
> breaking the raw-spinlocks only rule for Intel GPIO ISRs.
> 
> Make vsc_tp_isr() run as threaded ISR instead of as hard ISR to fix this.
> 

Reviewed-by: Alexander Usyskin <alexander.usyskin@...el.com>

> Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
> Link: https://lore.kernel.org/linux-gpio/18ab52bd-9171-4667-a600-
> 0f52ab7017ac@...nel.org/ [1]
> Signed-off-by: Hans de Goede <hansg@...nel.org>
> ---
>  drivers/misc/mei/vsc-tp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
> index f5ea38f22419..5ecf99883996 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -497,7 +497,7 @@ static int vsc_tp_probe(struct spi_device *spi)
>  	tp->spi = spi;
> 
>  	irq_set_status_flags(spi->irq, IRQ_DISABLE_UNLAZY);
> -	ret = request_threaded_irq(spi->irq, vsc_tp_isr, NULL,
> +	ret = request_threaded_irq(spi->irq, NULL, vsc_tp_isr,
>  				   IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
>  				   dev_name(dev), tp);
>  	if (ret)
> --
> 2.49.0