linux-kernel - Re: [PATCH V2] mmc: sdhci-msm: Ensure SD card power isn't ON when card removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a142960d-d30f-4845-86d3-a2b2888f1907@intel.com>
Date: Wed, 25 Jun 2025 13:25:09 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, Sarthak Garg
	<quic_sartgarg@...cinc.com>, Ulf Hansson <ulf.hansson@...aro.org>
CC: <linux-mmc@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <quic_cang@...cinc.com>,
	<quic_nguyenb@...cinc.com>, <quic_rampraka@...cinc.com>,
	<quic_pragalla@...cinc.com>, <quic_sayalil@...cinc.com>,
	<quic_nitirawa@...cinc.com>, <quic_bhaskarv@...cinc.com>,
	<kernel@....qualcomm.com>
Subject: Re: [PATCH V2] mmc: sdhci-msm: Ensure SD card power isn't ON when
 card removed

On 21/06/2025 13:59, Konrad Dybcio wrote:
>> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
>> index bf91cb96a0ea..97a895d839c9 100644
>> --- a/drivers/mmc/host/sdhci-msm.c
>> +++ b/drivers/mmc/host/sdhci-msm.c
>> @@ -1566,6 +1566,14 @@ static inline void sdhci_msm_complete_pwr_irq_wait(
>>  	wake_up(&msm_host->pwr_irq_wait);
>>  }
>>  
>> +static int get_cd(struct sdhci_host *host)
>> +{
>> +	struct mmc_host *mmc = host->mmc;
>> +	const struct mmc_host_ops *mmc_ops = READ_ONCE(mmc->ops);
> What do you need the READ_ONCE for?> +

Yeah I was confusing it with bus_ops.  READ_ONCE() is not needed.
sdhci already assumes mmc->ops->get_cd always exists, so
separate get_cd() is not much use.

With that and cosmetic changes, you can add:

Acked-by: Adrian Hunter <adrian.hunter@...el.com>