linux-kernel - Re: [PATCH v10 RESEND] wifi: mt76: mt7915: add wds support when wed is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26e6c7f7-a35f-4ebb-a55b-ade2ac7c20bb@nbd.name>
Date: Wed, 25 Jun 2025 12:18:07 +0200
From: Felix Fietkau <nbd@....name>
To: Shengyu Qu <wiagn233@...look.com>, pkshih@...ltek.com,
 lorenzo@...nel.org, ryder.lee@...iatek.com, shayne.chen@...iatek.com,
 sean.wang@...iatek.com, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, johannes.berg@...el.com,
 miriam.rachel.korenblit@...el.com, christophe.jaillet@...adoo.fr,
 greearb@...delatech.com, howard-yh.hsu@...iatek.com,
 StanleyYP.Wang@...iatek.com, deren.wu@...iatek.com,
 chui-hao.chiu@...iatek.com, quic_adisi@...cinc.com, gustavoars@...nel.org,
 razvan.grigore@...pirebyte.ro, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Cc: Sujuan Chen <sujuan.chen@...iatek.com>, Bo Jiao <bo.jiao@...iatek.com>
Subject: Re: [PATCH v10 RESEND] wifi: mt76: mt7915: add wds support when wed
 is enabled

On 24.06.25 16:11, Shengyu Qu wrote:
> Hi Felix,
> 
> Please, tell me if this patch needs any polishing. I really don't know
> why this patch still not get merged after such a long time(and 2x
> resend), especially it already got a Reviewed-by and is a bugfix.

Hi Shengyu,

sorry it took such a long time for me to take a look at this patch.
I don't see how it can even work properly in its current form, because 
of at least one bug:

When switching from non-wds to wds mode, the code calls 
mt7915_mac_sta_add in order to create the new sta. However, after 
changes that I made a while back, this function does not actually upload 
the station to the MCU anymore, since it is called on the NOTEXIST->NONE 
transition before assoc. Without corresponding ASSOC/AUTHORIZE events 
(handled by mt7915_mac_sta_event), the firmware doesn't get any data for 
the new wcid.

That said, I finally got around to starting to rework your patch myself. 
I will let you know when I have something ready for testing, hopefully 
later today.

- Felix